Skip to content

fix: show port numbers without a thousands separator #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arzafran merged 1 commit into from
Oct 20, 2026
Merged

fix: show port numbers without a thousands separator #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 6 additions & 23 deletions Resources/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12428,36 +12428,19 @@
}
}
},
"sidebar.port.label": {
"extractionState": "manual",
"localizations": {
"en": {
"stringUnit": {
"state": "translated",
"value": ":%lld"
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": ":%lld"
}
}
}
},
"sidebar.port.openTooltip": {
"extractionState": "manual",
"localizations": {
"en": {
"stringUnit": {
"state": "translated",
"value": "Open localhost:%lld"
"value": "Open localhost:%@"
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "localhost:%lldを開く"
"value": "localhost:%@を開く"
}
}
}
Expand Down Expand Up @@ -16718,13 +16701,13 @@
"en": {
"stringUnit": {
"state": "translated",
"value": "Stop %@ on port %lld?"
"value": "Stop %@ on port %@?"
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "ポート%2$lldの%1$@を停止しますか?"
"value": "ポート%2$@の%1$@を停止しますか?"
}
}
}
Expand All @@ -16735,13 +16718,13 @@
"en": {
"stringUnit": {
"state": "translated",
"value": "Programa asks process %lld to quit, and force-stops it if it is still running after 3 seconds."
"value": "Programa asks process %@ to quit, and force-stops it if it is still running after 3 seconds."
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "Programaはプロセス%lldに終了を要求し、3秒後も動作している場合は強制終了します。"
"value": "Programaはプロセス%@に終了を要求し、3秒後も動作している場合は強制終了します。"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions Sources/PortsHubView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ enum PortsHubActions {
alert.alertStyle = .warning
alert.messageText = String(
localized: "dialog.stopPort.title",
defaultValue: "Stop \(command) on port \(port)?"
defaultValue: "Stop \(command) on port \(String(port))?"
)
alert.informativeText = String(
localized: "dialog.stopPort.message",
defaultValue: "Programa asks process \(pid) to quit, and force-stops it if it is still running after 3 seconds."
defaultValue: "Programa asks process \(String(pid)) to quit, and force-stops it if it is still running after 3 seconds."
)
alert.addButton(withTitle: String(localized: "dialog.stopPort.cancel", defaultValue: "Cancel"))
alert.addButton(withTitle: String(localized: "dialog.stopPort.confirm", defaultValue: "Stop"))
Expand Down
4 changes: 2 additions & 2 deletions Sources/TabItemView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,11 +699,11 @@ struct TabItemView: View, Equatable {
Button(action: {
openPortLink(port)
}) {
Text(String(localized: "sidebar.port.label", defaultValue: ":\(port)"))
Text(verbatim: ":\(port)")
.underline()
}
.buttonStyle(.plain)
.safeHelp(String(localized: "sidebar.port.openTooltip", defaultValue: "Open localhost:\(port)"))
.safeHelp(String(localized: "sidebar.port.openTooltip", defaultValue: "Open localhost:\(String(port))"))
}
Spacer(minLength: 0)
}
Expand Down
Loading