fix(basket): use direct delivery when self-hosting - #815
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5480a50 to
a5e55e6
Compare
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
|
@greptileai review this |
SELFHOST=truemakes Basket, Links, and Uptime operate without Kafka, even when copied environment settings contain a broker. Links reuses its acknowledged ClickHouse fallback; Uptime writes directly to ClickHouse through its existing durable delivery worker. Health checks follow the active dependencies.Hosted Kafka behavior and protection against ambiguous delivery retries are preserved. Uptime direct delivery is at least once: failed writes retry, and a timeout can produce a duplicate. No schema changes or new services.
Validation: Basket 507, Links 27, and Uptime 58 tests; root lint and all 33 typecheck tasks; pre-push tests. Combined self-host smoke verified all three health endpoints with an invalid broker, a real synthetic Uptime write/read, and HTTP 503 from all three when ClickHouse stopped.
Depends on #806 for
SELFHOSTforwarding through Turbo. Complements #804 and #805. Overlaps #721 only in Links producer/tests; based directly on staging, with no code taken from that feature branch.Summary by cubic
When
SELFHOST=true, Basket, Links, and Uptime deliver directly to ClickHouse and ignore copied broker settings; health checks follow the active delivery path and hosted Kafka behavior is unchanged.Written for commit 70d20cb. Summary will update on new commits.