You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Message: Exported func New returns unexported type *crane.command, which can be annoying to use.
Fix
Export the command struct as Command (and its method receivers) so the exported New constructor returns an exported *Command. The local variable in PullConfigFromSource that was named command is renamed to cmd to avoid shadowing the now-exported type name.
The change is purely a naming/export change — no behavioral change. New, WithFlag, WithArg, and Run keep the same signatures (now returning *Command).
Verification
task cli:format � clean (gofmt/gci/gofumpt via golangci-lint fmt)
task cli:lint:ci � 0 issues
task cli:test � all packages pass except the known pre-existing pkg/gitTestRepoClone* failures (stale assertion on origin/main, unrelated to this change which does not touch pkg/git)
This PR was created by an AI agent as part of an automated daily Codefactor issue fix job.
Export the crane command type so New returns an exported *Command, resolving the Codefactor maintainability issue (exported func returns unexported type).
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
Tick the box to add this pull request to the merge queue (same as @mergifyio queue).
Queue this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codefactor issue
6a77b13d5b1ec0b4ee20c455pkg/devcontainer/crane/run.go:37Newreturns unexported type*crane.command, which can be annoying to use.Fix
Export the
commandstruct asCommand(and its method receivers) so the exportedNewconstructor returns an exported*Command. The local variable inPullConfigFromSourcethat was namedcommandis renamed tocmdto avoid shadowing the now-exported type name.The change is purely a naming/export change — no behavioral change.
New,WithFlag,WithArg, andRunkeep the same signatures (now returning*Command).Verification
task cli:format� clean (gofmt/gci/gofumpt via golangci-lint fmt)task cli:lint:ci� 0 issuestask cli:test� all packages pass except the known pre-existingpkg/gitTestRepoClone*failures (stale assertion onorigin/main, unrelated to this change which does not touchpkg/git)This PR was created by an AI agent as part of an automated daily Codefactor issue fix job.