Skip to content

fix: export crane command type #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devsy-app wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: export crane command type #1048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d05c5c5
fix: export crane command type
devsy-app[bot] Aug 14, 2026
82ea460
Merge branch 'main' into fix/codefactor/crane-export-command
skevetter Aug 17, 2026
93555a4
Merge branch 'main' into fix/codefactor/crane-export-command
skevetter Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions pkg/devcontainer/crane/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,27 +29,27 @@ type Content struct {
Files map[string]string `json:"files"`
}

type command struct {
type Command struct {
cmd string
args []string
}

func New(cmd string) *command {
newCommand := &command{cmd: getBinName()}
func New(cmd string) *Command {
newCommand := &Command{cmd: getBinName()}
return newCommand.WithArg(cmd)
}

func (c *command) WithFlag(flag, val string) *command {
func (c *Command) WithFlag(flag, val string) *Command {
c.args = append(c.args, flag, val)
return c
}

func (c *command) WithArg(arg string) *command {
func (c *Command) WithArg(arg string) *Command {
c.args = append(c.args, arg)
return c
}

func (c *command) Run() (string, error) {
func (c *Command) Run() (string, error) {
cmd := exec.Command(c.cmd, c.args...)

var outBuf, errBuf bytes.Buffer
Expand Down Expand Up @@ -85,15 +85,15 @@ func PullConfigFromSource(
return "", fmt.Errorf("failed to pull config from source based on options")
}

command := New(PullCommand).
cmd := New(PullCommand).
WithArg(EnvironmentCrane).
WithArg(options.Platform.EnvironmentTemplate)

if options.Platform.EnvironmentTemplateVersion != "" {
command = command.WithFlag("--version", options.Platform.EnvironmentTemplateVersion)
cmd = cmd.WithFlag("--version", options.Platform.EnvironmentTemplateVersion)
}

data, err = command.Run()
data, err = cmd.Run()
if err != nil {
return "", err
}
Expand Down
Loading