Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: ad1a6d5 | Previous: 17fdb6b | Ratio |
|---|---|---|---|
peak memory |
1639.457 MB |
1589.477 MB |
1.03 |
peak threads |
364 threads |
350 threads |
1.04 |
network (transport) |
2730.031 MB |
2730.079 MB |
1.00 |
disk write |
1.934 MB |
1.707 MB |
1.13 |
instructions |
121.417 G |
115.497 G |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Image/CompressedImage, CameraInfo and PointCloud2 values now have explicit array, compression, calibration and geometry adapters. They retain source Headers, padding, byte order and extra cloud fields. Rerun renders these values without adding methods to generated classes, and pairs CameraInfo with images in either arrival order.
Project: Message Encoding Refactor. Based on #4652. This establishes the sensor value/renderer boundary; physical camera/perception modules, robot blueprints and default factories are not cut over in this draft. Those remain implementation scopes, not external blockers.
Use the values
The factory copies input data; the view is borrowed/read-only. Image and cloud operations stay outside the generated plain-value API. The embedded walkthrough also shows RGBD projection and compression; CI executes those three Python blocks verbatim.
Manual visual test
With this checkout installed normally into the active environment:
Use a new output. This exact example sends generated PoseStamped, RGB Image and calibrated RGBD cloud over discovery-disabled loopback Zenoh/CDR. The real RRD shows pose axes, colored points, full Pose/Header values and the RGB pixels. It refuses overwrite. The demo explicitly anchors its map frame; runtime frame names remain unchanged.
Parent-relative file changes
Total: 19 files, 3136 additions / 40 deletions, parent
70c08e85f4954e021111e55a11c0a5d1d35651e1, headad1a6d50c34431c7de182a0782a2077b21529460. No generated classes, vendored upstream sources, native locks or hardware SDK changes are checked in. The largest file is the 462-line point-cloud test; the largest production sources are pointcloud.py (380 lines) and geometry.py (376).Validation and limits
216 focused/compatibility checks passed, including actual JPEG/PNG/JXL, Open3D tensor downsampling, both camera/image arrival orders, the exact documentation blocks, the isolated loopback example and no-overwrite. Strict typing passes on eight production files; applicable configured hooks pass. A real SDK issue with single-row/column RGB inference is covered: the adapter now supplies explicit width/height and bytes. Depth rendering retains uint16 units and normalizes endian without changing source values.
This does not promise ROS-node integration, legacy recording conversion, human visual acceptance, hardware acceptance or terminal CI success. JXL remains an explicit consumer extension. M20 SDK/Foxglove sign-in and later domain/default/cleanup scopes are separate.
Final
ad1a6d50also sends CameraInfo over CDR and asserts the actual RRD pinhole. This fixes the 3D missing-calibration indicator found during real-browser acceptance. The same216 checks pass against the installed production wheel with the current exact example; pip check passes in the private proof environment.