Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: e530aec | Previous: 97344c8 | Ratio |
|---|---|---|---|
peak memory |
1717.527 MB |
1602.453 MB |
1.07 |
peak threads |
369 threads |
356 threads |
1.04 |
network (transport) |
2722.164 MB |
2724.755 MB |
1.00 |
disk write |
1.816 MB |
1.742 MB |
1.04 |
instructions |
133.062 G |
114.909 G |
1.16 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TF lookups, static frame publication and recorded-stream queries now use generated
TransformStamped,PoseStampedandTFMessagevalues fromdimos.messages. The query/publish argument names and seconds-based lookup interface remain unchanged. Geometry operations use the existing proposal helpers rather than rich wire classes.Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Stack dependencies
Base: #4657 (native TF / RealSense). This layer also includes the unchanged recording prerequisite from #4645 (
fe5a5260, cherry-picked as8a27beb1). It is shared dependency code, not a second recording implementation. Final stack alignment is pending the remaining consumer migrations.File changes
Counts above are the TF commit
e530aec6relative to its recording prerequisite8a27beb1. The full parent-relative diff includes the unchanged #4645 prerequisite: 20 files, 1,438 additions and 777 deletions. Generated-at-build outputs are not checked in.Manual review
From this PR checkout, use the normal project development environment:
Then copy and run any complete block from Transforms. The “Attach a stream” block is a complete offline CDR publication/lookup example using
memq://, with transport/subscription cleanup. No device or host multicast setup is needed.Verified locally
No terminal CI result is claimed. Benchmark investigation remains paused. Device operation, Nix derivation evaluation, default-host multicast, proprietary M20 SDK access and external viewer sign-in/human acceptance are separate unverified gates. This layer retains explicit CDR transport selection until the default runtime cutover is complete.