Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OdometryHist now consumes generated Odometry and publishes generated Path values. It reads the standard nested pose, retains each captured PoseStamped Header, and compares source nanoseconds for the existing publication interval/replay-reset logic. Generated snapshots own their pose data. Rerun renders generated Path geometry and its full source fields outside the value class; the existing true-height override also continues to accept legacy Path callers.
Parent: #4671. Part of the message encoding refactor.
Check the generated value/renderer from the proposal's installed main package:
From a prepared checkout,
python -m pytest --noconftest -o addopts='' -q dimos/mapping/test_generated_odometry_hist.py dimos/visualization/rerun/test_cdr.pyruns 21 checks, including actual CDR input dispatch and output. It needs normal local process IPC, with RPC/CDR explicitly usingmemq://; no external network or assets.Validation: 21 source and 21 installed-main-wheel checks pass, with actual production modules asserted to come from site-packages. Two production files pass strict typing; applicable hooks, normal main wheel and default 198-package pip check pass. The exact renderer block also ran in the default-dependency installed environment. Wheel SHA256
22d5b3723e9c752c2543eb8a5a960b9d8064b45dd5871a12679c4071898db8cc.The restricted local executor blocked
socketpair.sendwith EPERM and could not wake asyncio; the same bounded checks passed when local IPC was permitted. No core scheduler/API workaround was added. No hardware, simulator, benchmark investigation, human visual acceptance or CI polling. Remaining odometry producers/default encoding and legacy retirement stay in subsequent cutover work.