Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic/Fancy Python trajectory followers use generated Path/PoseStamped/TFMessage/Twist/Bool values. The existing laws, gains, lookahead, deadman, arrival latch, stop handling and scheduling stay intact. Profile decoding subtracts integer nanoseconds before converting deltas to seconds; the optional Rust law adapter receives relative seconds, avoiding epoch float loss.
Parent: #4679. Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
After installing this commit, this directly computes a command without hardware or the optional Rust extension:
For the actual SDK Module pub/sub acceptance, from the dev checkout run:
python -m pytest --noconftest --import-mode=importlib -o addopts='' -q \ dimos/navigation/trajectory_follower/test_generated_ports.pyBoth actual modules use CdrTransport/MemoryRPC memq ports: TF + dense Path → forward Twist → updated TF at goal → arrival Bool → new goal drives → empty Path stops. All threads/subscriptions/transports are cleaned; no robot or fixed sleeps.
Validation: 49 source and 49 installed-wheel checks, including real compiled Rust law numerical parity with the original strict component/headroom assertions. Seven production files pass strict typing; applicable hooks, main wheel build and full default runtime pip check (198 packages) pass. The exact Python block above runs against the installed main wheel. Two old precision fixtures required sub-nanosecond timestamps; their distance/time inputs now use exactly representable ROS timing while retaining the original speed sweep/assertions/tolerances.
The optional Rust math wheel was built offline with Cargo --locked and 2 jobs; it is not a native transport module. Full native follower/local-planner Rust wire integration, other robot consumers, default cutover and legacy retirement remain later layers. Nix, hardware, performance and GitHub CI results are not claimed.