Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native SE(2) local planner now consumes generated
PointCloud2,PathandTFMessageCDR values and publishes a generatedPath, matching the Python planner ports. Existing search geometry, embodiment settings, RPC names and raw LCM/Zenoh transports remain unchanged.Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4681. This is one consumer layer of the ongoing migration, not the final default/legacy cleanup.
Manual test from this checkout, with Python development dependencies installed and a Rust toolchain:
This starts only a synthetic native planner and an explicitly local Zenoh router, sends Python-generated TF/cloud/path CDR and checks the returned canonical route. It owns process/session cleanup and does not operate hardware. Set the binary variable: omitting it intentionally skips the binary acceptance case.
Validated locally: 63 Rust unit tests and 5 integration tests from a standalone source assembly without checkout parent paths; all-target Clippy with warnings denied; actual binary interoperability (2 Python tests), also repeated with production modules loaded from the installed main wheel; strict typing for the Python wrapper; applicable hooks; main wheel build and the existing 198-package environment's dependency check. Wheel SHA256:
0aad3caa0fbf4f8544da0e86e8801a0fdef0961bf35050bf321d667e81f16b5c.Limits: Nix executable is absent locally, so the updated flake has not been Nix-built. Its equivalent standalone Cargo source assembly was tested, which does not replace the Nix gate. Source TF metadata retains nanoseconds; SDK query windows still use the existing floating-point API, and newly computed plan timestamps retain the existing wall-clock representation. Legacy SDK message dependencies remain until their remaining consumers are migrated. CI was not polled; no all-green, hardware or human acceptance claim.