Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit region metadata for the ray-tracing/MLS cutover. Those streams currently use legacy
Header.seqas a packed viewer-cell key or seed-region pairing ID; canonical ROS2std_msgs/Headerhas no such field. These small DimOS-owned message definitions retain that information without modifying or duplicating upstream standard types.Project: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4686. Native consumers follow in the next layer; this prerequisite does not claim the mapper/MLS runtime is migrated yet.
.msgdefinitionsPointCloudRegion, cylindricalRegionBounds,LineSegments3DRegion, with explicit signedregion_idand normal Header stampsPointCloudRegionreferencessensor_msgs/PointCloud2;LineSegments3DRegionreferences the existing weightedLineSegments3D. Their outer Headers match their payload Headers so generic recording can read source time.RegionBoundshas explicit center/radius/z limits rather than storing cylinder dimensions in a quaternion. These are value definitions, not new Module handlers or convenience classes. No generated outputs or copied upstream.msgcode are checked in.Manual Python acceptance after installing this checkout:
Local evidence: 10 source tests and the same 10 using the installed main wheel pass, including an independent rosbags subprocess starting with an empty type store and reading only the full schemas embedded in MCAP. Compiled and ran an actual Rust consumer constructing all three values. Python decoded and re-encoded each Rust CDR payload identically; a compiled C++ consumer decoded and re-encoded those same payloads identically, with compile-time checks for the reused Header/PointCloud2 declarations. C++ preparation was offline using the cached nine Git source revisions checked against the generator lock and existing FastCDR sources. No ROS installation was required.
Applicable hooks, normal main-wheel build and the existing 198-package environment's dependency check pass. Wheel SHA256:
a9eb6f4d48744164e16e87026d8b7eff992cc2b68278d35307c65158fd917963. Existing native package consumers in CI compile the generated catalog; the new focused gate checks region payloads and MCAP closure. No CI polling/all-green, native mapper runtime, hardware, viewer or human acceptance claim.