Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated message ports previously fell through to pickle because generated classes do not expose
lcm_encode. The default factory now selects registry-owned CDR on the configured LCM or Zenoh backend. The existing Python → C++ → Rust → Python example uses ordinary coordinator wiring without manual transport maps. Sensor QoS recognizes canonical names, with never-drop channel precedence retained.Linear: https://linear.app/dimensional/project/message-encoding-refactor-05a3ddb4af3e/overview
Parent: #4695. This is the default generated-port boundary cutover; legacy typed ports and Python-object channels retain their distinct paths. No wire negotiation or old-recording fallback. Full graph/recorder/fixture acceptance and eventual legacy dependency retirement remain separate open gates.
Manual local smoke (after installing this proposal checkout and its test dependencies):
LCM_DEFAULT_URL=memq:// python -m pytest --noconftest -o addopts='' -q dimos/core/test_transport_factory.py dimos/core/test_cdr_transport.pyThe external example's existing CMake/Cargo build instructions remain in
docs/development/messages-external-project.md; after building, from that external project:Expected:
PASS: coordinator Python -> C++ -> Rust -> Python over loopback Zenoh CDR. Manual execution requires an interactive terminal; decline optional host setup. No robot is used.Validation: 37 source tests and 37 isolated installed-wheel tests passed (production modules preloaded from site-packages), two production files passed strict mypy, configured scoped hooks passed except unavailable Nix lint. Actual installed SDK example compiled C++/Rust and completed the default-factory coordinator exchange, including exact shared Header identity and the noninteractive manual refusal test. Main wheel built: SHA256
bbbe0c8d54a2b045d7993ff653f01ed07dd0cb24c3f8edcd355bf53c860c6044. First two native acceptance attempts exposed local CMake/pkg-config invocation omissions; corrected cached dependency paths passed. No CI polling, benchmark, hardware, or publication to a package registry.