Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard teleoperation now publishes generated CDR TwistStamped/Float32 values matching the manipulator coordinator inputs. Key mapping, speed scales, immediate zero on final motion-key release and normalized gripper command deduplication remain unchanged. New command headers use integer wall-clock nanoseconds.
Parent: #4702. Message Encoding Refactor
Manual offline acceptance (headless, no pygame window or robot):
DIMOS_TRANSPORT=lcm LCM_DEFAULT_URL=memq:// uv run pytest --noconftest --import-mode=importlib -o addopts='' -q dimos/teleop/keyboard/test_keyboard_teleop_module.pySynthetic pygame key events exercise the actual publisher. Real LCM memq and discovery-disabled loopback Zenoh deliver a generated velocity, key-release zero and gripper opening; the timestamp retains epoch + 1ns. All previous key mapping and deduplication assertions remain.
Validation: 10 source + 10 installed-wheel tests, one production file strict typing, scoped configured hooks passed except unavailable Nix lint. Wheel SHA256:
9daa0130a6f5b7ae71d46fb04cccfaf901fac8f58b80961385f0be99b1c9046c.No interactive display, physical control, hardware, package publication or CI polling. Hosted teleop/recording/simulation boundaries and final legacy dependency retirement remain separate work.