Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic
MujocoSimModulecamera/cloud/calibration/odom/IMU/TF ports now expose generated CDR values. Existing projection, Open3D voxel math and numerical controllers remain behind explicit wire adapters. Those shared adapters move from the Unitree folder todimos/msgs/driver.py(one file moved, not another copy). G1 custom costmap/path/odom viewers accept the same canonical wire values.Parent: #4713. Message encoding refactor.
Fresh physics odom/IMU share an exact integer-nanosecond stamp; camera streams keep the frame's simulator clock, with the existing before-first-frame wall fallback. Calibration RPCs return canonical values with independent matrices. The old numerical transform, camera and cloud APIs remain internal; this does not close Gate B legacy dependency retirement.
Manual offline acceptance from the configured checkout:
DIMOS_TRANSPORT=lcm LCM_DEFAULT_URL=memq:// uv run pytest --noconftest --import-mode=importlib -o addopts='' -q \ dimos/simulation/engines/test_cdr_streams.py \ dimos/simulation/engines/test_mujoco_sim_module.py47 source +47 isolated installed-wheel tests, strict typing7 production files, applicable hooks and wheel pass; Nix unavailable. Wheel SHA256
6c29ad7bbf18e60eaeb857c26ba25a89e8a660d72cf063771520bf8e766bc933.Actual bounded headless CPU MuJoCo runs an inline tiny MJCF with real physics and task-owned SHM, publishes real CDR odom/IMU on memq and discovery-disabled loopback Zenoh, asserts epoch+1ns and that physics/publisher threads and SHM close. A deterministic render-frame boundary exercises the existing actual RGBD/Open3D projection and CDR RGB/depth/cloud/calibration, with exact pixels/points/colors/source stamp and RPC matrix ownership. Actual Rerun archetypes assert G1 mesh/path geometry and odometry placement. Existing simulation clock/TF/reset/respawn and G1/Go2 fidelity regressions remain.
No robot, external model/scene asset, policy weights/inference, GPU rendering, display, performance experiment or human visual acceptance. QP-solver-absent warning is retained; no IK solve claimed. Remaining R1 sensor/LIO, collection/native-worker/DimSim/Habitat/other promised graphs, canonical fixtures, default/compatibility audit, Gate B retirement and final ancestry/PR-chain organization remain open. No CI polling.