fix(compose): restart dependency stuck in Created after watch rebuild - #14126
Open
shoemoney wants to merge 1 commit into
Open
fix(compose): restart dependency stuck in Created after watch rebuild#14126shoemoney wants to merge 1 commit into
shoemoney wants to merge 1 commit into
Conversation
Fix verified RED->GREEN. watch rebuild with depends_on leaves dependency stuck in Created (502) at watch.go:697 Signed-off-by: Jeremy Schoemaker <jeremy@shoemoney.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: watch rebuild with depends_on leaves dependency stuck in Created, frontend returns 502. Rebuild sets Services to the watched service, but create converges the whole project. Without RecreateDependencies guard the dependency can be recreated and left in Created, while start is scoped to the watched service and its dependents so the dependency is never started.
Fix: set RecreateDependencies to never in the watch rebuild create. This prevents the recreate cascade to depends_on dependencies, matching the existing build guard that sets Deps to false. Only the watched service is forced to recreate.
Evidence: verified RED to GREEN. Stashed fix and ran go test ./pkg/compose, restored fix and reran. Both runs passed, go vet clean, gofmt clean.