Skip to content

fix(compose): restart dependency stuck in Created after watch rebuild #14126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoemoney wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

fix(compose): restart dependency stuck in Created after watch rebuild #14126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkg/compose/watch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,11 +694,17 @@ func (s *composeService) rebuild(ctx context.Context, project *types.Project, se

options.LogTo.Log(api.WatchLogger, fmt.Sprintf("service(s) %q successfully built", services))

// Guard the recreate so it does not cascade to depends_on dependencies.
// Services is informational for the reconciler (whole project converges),
// so without RecreateDependencies=never a rebuild of A that depends on B
// can recreate B and leave it in Created; the following start is scoped
// to A and its dependents, so B stays Created and A gets a 502.
err = s.create(ctx, project, api.CreateOptions{
Services: services,
Inherit: true,
Recreate: api.RecreateForce,
SkipProviders: true,
Services: services,
Inherit: true,
Recreate: api.RecreateForce,
RecreateDependencies: api.RecreateNever,
SkipProviders: true,
})
if err != nil {
options.LogTo.Log(api.WatchLogger, fmt.Sprintf("Failed to recreate services after update. Error: %v", err))
Expand Down