Skip to content

Add clear button(SWT.ICON_CANCEL) to Quick Switch(Ctrl+E) filter field. - #4465

Merged
elsazac merged 1 commit into
eclipse-platform:masterfrom
deepika-u:ctrlE_icon_cancel
Oct 9, 2026
Merged

elsazac merged 1 commit into
eclipse-platform:masterfrom
deepika-u:ctrlE_icon_cancel

Conversation

@deepika-u

Copy link
Copy Markdown
Contributor

This PR adds native cancel/clear button (SWT.ICON_CANCEL) support to the filter search field in the Quick Switch dialog (Ctrl+E) and related filtered table handlers (FilteredTableBaseHandler).

Motivation & UX Improvement

  • When filtering through open editors using Quick Switch (Ctrl+E), clearing a query previously required selecting all text or pressing Backspace repeatedly.
  • Configuring the search Text widget with SWT.SEARCH | SWT.ICON_CANCEL displays a native "x" cancel icon inside the field whenever text is entered.
  • Clicking the cancel button immediately resets the filter query and restores the full list of open items.
  • Omits SWT.ICON_SEARCH to maximize usable horizontal typing width within the dialog.

As suggested by @merks in #4457 (comment)

@deepika-u deepika-u changed the title Add clear button (SWT.ICON_CANCEL) to Quick Switch (Ctrl+E) filter field. Add clear button(SWT.ICON_CANCEL) to Quick Switch(Ctrl+E) filter field. Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   59m 53s ⏱️ + 6m 47s
 8 411 tests ±0   8 169 ✅ ±0  242 💤 ±0  0 ❌ ±0 
21 102 runs  ±0  20 419 ✅ ±0  683 💤 ±0  0 ❌ ±0 

Results for commit b39cd54. ± Comparison against base commit 4d33940.

♻️ This comment has been updated with latest results.

@elsazac
elsazac force-pushed the ctrlE_icon_cancel branch from 27f0cf2 to b39cd54 Compare October 9, 2026 09:05

@elsazac elsazac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elsazac
elsazac merged commit f8b27f5 into eclipse-platform:master Oct 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants