Skip to content

Add clear button(SWT.ICON_CANCEL) to Quick Switch(Ctrl+E) filter field. #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elsazac merged 1 commit into from
Oct 9, 2026
+8 −2
Merged

Add clear button(SWT.ICON_CANCEL) to Quick Switch(Ctrl+E) filter field. #4465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .../org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/FilteredTableBaseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2017 Patrik Suzzi and others.
* Copyright (c) 2017, 2026 Patrik Suzzi and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -10,6 +10,7 @@
*
* Contributors:
* Patrik Suzzi <psuzzi@gmail.com> - Bug 368977, 504088, 504089, 504090, 504091, 509232, 506019
* IBM Corporation - Add clear button to CTRL+E shortcut to clear filter text.
******************************************************************************/

package org.eclipse.ui.internal;
Expand Down Expand Up @@ -169,9 +170,14 @@ public void openDialog(WorkbenchPage page, IWorkbenchPart activePart) {
composite.setLayout(gl_composite);

if (isFiltered()) {
text = new Text(composite, SWT.NONE);
text = new Text(composite, SWT.SEARCH | SWT.ICON_CANCEL);
text.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, false, false, 1, 1));
text.setBackground(getBackground());
text.addListener(SWT.DefaultSelection, event -> {
if (event.detail == SWT.ICON_CANCEL) {
text.setText(EMPTY_STRING);
}
});
} else {
/*
* For issues with dark theme, don't use table.setHeaderVisible(true); and
Expand Down
Loading