Skip to content

fix(database,windows): marshal listener callbacks onto the platform thread - #18656

Open
SelaseKay wants to merge 3 commits into
mainfrom
fix/database-windows-platform-thread
Open

fix(database,windows): marshal listener callbacks onto the platform thread#18656
SelaseKay wants to merge 3 commits into
mainfrom
fix/database-windows-platform-thread

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

On Windows, Realtime Database listener callbacks and Future::OnCompletion replies were sent to Flutter from the C++ SDK worker thread. That trips the engine's non-platform-thread check and can crash the process; cancelling a subscription could also delete a listener while OnValueChanged was still running.

This hops EventSink and Pigeon replies onto the platform thread (same HWND dispatcher pattern as cloud_firestore) and serializes listener teardown with in-flight SDK callbacks.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

…hread

SDK callbacks were writing to Flutter EventSinks and Pigeon replies from a worker thread, which crashes the Windows embedder. Hop those calls onto the platform thread and serialize listener teardown with in-flight callbacks.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

MSVC prefers the optional<FlutterError> overload over the ErrorOr template when the second argument is a raw EncodableMap. Spell the template argument so QueryGet can compile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_database, windows] Listener callbacks are delivered on a non-platform thread and crash the process

1 participant