Skip to content

fix(database,windows): marshal listener callbacks onto the platform thread #18656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SelaseKay wants to merge 3 commits into
base: main
Choose a base branch
from
+425 −190
Open

fix(database,windows): marshal listener callbacks onto the platform thread #18656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76907d8
fix(database,windows): marshal listener callbacks onto the platform t…
SelaseKay Sep 7, 2026
cc0d064
style(database,windows): apply clang-format to platform-thread hop
SelaseKay Sep 7, 2026
a8db272
fix(database,windows): disambiguate ReplyOnPlatformThread for QueryGet
SelaseKay Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/firebase_database/firebase_database/example/integration_test/query_e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,24 @@ void setupQueryTests() {
skip: defaultTargetPlatform != TargetPlatform.android,
);

test(
'cancels in-flight value listeners on distinct paths without error',
() async {
final errors = <Object>[];

for (var i = 0; i < 64; i++) {
final subscription = ref
.child('cancel-inflight-${i % 16}')
.onValue
.listen((_) {}, onError: errors.add);
await Future<void>.delayed(Duration(milliseconds: i * 7 % 50));
await subscription.cancel();
}

expect(errors, isEmpty);
},
);

test(
'throw a `permission-denied` exception when accessing restricted data',
() async {
Expand Down
Loading
Loading