Repository navigation
feat: raise the pitch limit to 85° with a far limit of the visible ground - #2291
Open
greensopinion wants to merge 1 commit into
Open
greensopinion wants to merge 1 commit into
greensopinion wants to merge 1 commit into
Conversation
MapOptions.pitchLimit is now 85. Above a pitch of about 71°, the visible ground ends at a far limit, where the view ray is 89.25° from straight down, as in MapLibre Native. Above it, ground layers draw nothing and the background color shows, markers and polygon labels are not drawn, and gestures act at the far limit directly below the pointer. The visible bounds, tile cover and camera fits use the ground below the far limit. Up to a pitch of about 71° nothing changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapOptions.pitchLimit is now 85. Above a pitch of about 71°, the visible
ground ends at a far limit, where the view ray is 89.25° from straight
down, as in MapLibre Native. Above it, ground layers draw nothing and the
background color shows, markers and polygon labels are not drawn, and
gestures act at the far limit directly below the pointer. The visible
bounds, tile cover and camera fits use the ground below the far limit.
Up to a pitch of about 71° nothing changes.
Depends on #2289.
I wrote this with Claude Code (Claude Opus 5.5). I directed the design,
reviewed the code, and tested it on a Mac and an iPhone 13, and measured
it on a Pixel 4a (5G).