Skip to content

fix(win): accept minimal PDB70 CodeView records - #169

Merged
jpnurmi merged 3 commits into
getsentryfrom
jpnurmi/fix/codeview
Aug 20, 2026
Merged

fix(win): accept minimal PDB70 CodeView records#169
jpnurmi merged 3 commits into
getsentryfrom
jpnurmi/fix/codeview

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Validate the serialized record length instead of the padded C++ struct size so records with an empty PDB filename are accepted.

Tested by:

Original issue:

Validate the serialized record length instead of the padded C++ struct
size so records with an empty PDB filename are accepted.
Comment thread snapshot/win/pe_image_reader.cc
Reject malformed PDB70 records without a trailing NUL before
constructing a string from the filename field.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8b6a5ac. Configure here.

Comment thread snapshot/win/pe_image_reader.cc
Comment thread snapshot/win/pe_image_reader.cc
@jpnurmi
jpnurmi merged commit 95733c1 into getsentry Aug 20, 2026
27 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/fix/codeview branch August 20, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants