fix(crashpad): preserve UUIDs from minimal PDB70 records - #2003
Open
jpnurmi wants to merge 6 commits into
Open
Conversation
Parse module CodeView records from uploaded minidumps and assert the example module carries a non-zero UUID.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9383db2. Configure here.
Target the SDK shared library and accept both PDB70 and ELF build-ID record signatures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
+ Coverage 74.41% 74.47% +0.06%
==========================================
Files 104 104
Lines 25913 25913
Branches 4691 4691
==========================================
+ Hits 19282 19299 +17
+ Misses 5299 5275 -24
- Partials 1332 1339 +7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reproduces #2002 with the MinGW CI job:
Proposed fix:
Close: #2002