chore: deprecate enable_logs/metrics - #2000
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
+ Coverage 74.32% 74.43% +0.11%
==========================================
Files 104 104
Lines 25807 25913 +106
Branches 4668 4691 +23
==========================================
+ Hits 19180 19289 +109
+ Misses 5303 5294 -9
- Partials 1324 1330 +6 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
The more I think about it, the more I like the previous version, because it's more honest. If someone calls sentry_options_set_enable_logs(options, false) on this version, they'll get a warning, but application will compile and run, and produce a different result than before. It's a sneaky footgun.
| static sentry_batcher_ref_t g_batcher = SENTRY_BATCHER_REF_INIT; | ||
|
|
||
| static bool | ||
| sdk_is_initialized(void) |
There was a problem hiding this comment.
Other SDKs usually provide is_enabled() to check whether it's initialized. Just an idea, and probably out of scope for this PR.
Good point! A bare deprecation without ripping out the functionality just yet makes more sense, indeed. |
A softer alternative to #1980, to be released with the current features and fixes. This provides a heads-up for the actual removal coming soon, together with the other upcoming breaking changes (e.g. value-based attachments for RW-locking).