chore(transport): Record tokio thread client report losses#1186
Open
szokeasaurusrex wants to merge 2 commits into
Open
Conversation
szokeasaurusrex
changed the title
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
from
614c2e1 to
bdff5cb
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tokio-thread-client-reports
branch
from
265a9fb to
de9f7c8
Compare
lcian
reviewed
Jun 22, 2026
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
from
bdff5cb to
db28b96
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tokio-thread-client-reports
branch
from
de9f7c8 to
d7d314c
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tokio-thread-client-reports
branch
from
d7d314c to
d5d1597
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
from
db28b96 to
96a15e5
Compare
Record envelopes dropped before the reqwest HTTP transport sees them. The tokio transport thread now reports queue overflow, disconnected worker, and rate-limit drops through the client report recorder. Shutdown losses remain unreported because shutdown ends the opportunity to send another envelope carrying the aggregated client report. Fixes [#1150](#1150) Fixes [RUST-225](https://linear.app/getsentry/issue/RUST-225)
Record dropped envelopes through the client report recorder directly in the tokio transport thread. This matches the newer recorder API and removes the old transport helper import from this implementation.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tokio-thread-client-reports
branch
from
d5d1597 to
807212a
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-thread-client-reports
branch
from
96a15e5 to
11f9014
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 807212a. Configure here.
| None => { | ||
| sentry_debug!("Envelope was discarded due to per-item rate limits"); | ||
| }, | ||
| } |
There was a problem hiding this comment.
Orphan attachments misreported rate limits
Medium Severity
Replacing filter_envelope with rl.filter and a client-report recorder makes every on_filtered callback record RatelimitBackoff. Envelope::filter also invokes on_filtered when it strips attachments that lack an event or transaction, so those policy drops can be counted as rate-limit losses even when no rate limit applied.
Reviewed by Cursor Bugbot for commit 807212a. Configure here.
lcian
reviewed
Jun 22, 2026
| let auth = dsn.to_auth(Some(&user_agent)).to_string(); | ||
| let url = dsn.envelope_api_url().to_string(); | ||
|
|
||
| let send_fn_client_report_recorder = client_report_recorder.clone(); |
Member
There was a problem hiding this comment.
Suggested change
| let send_fn_client_report_recorder = client_report_recorder.clone(); | |
| let client_report_recorder = client_report_recorder.clone(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record envelopes dropped before the reqwest HTTP transport sees them. The tokio transport thread now reports queue overflow, disconnected worker, and rate-limit drops through the client report recorder.
Shutdown losses remain unreported because shutdown ends the opportunity to send another envelope carrying the aggregated client report.
Fixes #1150
Fixes RUST-225