fix: avoid self-matching KVM process probes - #7927
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
lpcox
added
the
cloud-hypervisor-kvm
Contributor
|
🚀 Security Guard has started processing this pull request |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes consistently fix self-matching probes and include appropriate regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Prevents KVM cleanup/liveness probes from matching their own pgrep command lines.
Changes:
- Uses self-excluding patterns for Cloud Hypervisor and virtiofsd.
- Adds regression coverage for probe behavior.
- Updates workflow cleanup validation.
| File | Description |
|---|---|
scripts/ci/cloud-hypervisor-live-smoke.sh |
Corrects process probes. |
scripts/ci/cloud-hypervisor-ci-scripts.test.ts |
Tests self-exclusion and target matching. |
scripts/ci/test-cloud-hypervisor-workflow.test.ts |
Verifies workflow probe syntax. |
.github/workflows/test-cloud-hypervisor.yml |
Corrects final residue probe. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgrepexpressions self-excludingValidation
npm test -- --runInBand scripts/ci/cloud-hypervisor-ci-scripts.test.ts scripts/ci/test-cloud-hypervisor-workflow.test.tsbash -n scripts/ci/cloud-hypervisor-live-smoke.shnpm run buildnpm run lintnpm test -- --runInBandFixes the false residue detection observed in the post-merge live-KVM run for #7922.