Skip to content

docs: remove resolved MCP gateway Docker socket limitation from ARC/DinD guide#46045

Open
lpcox with Copilot wants to merge 12 commits into
mainfrom
copilot/update-arc-dind-guide
Open

docs: remove resolved MCP gateway Docker socket limitation from ARC/DinD guide#46045
lpcox with Copilot wants to merge 12 commits into
mainfrom
copilot/update-arc-dind-guide

Conversation

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Issue #44251 (MCP gateway Docker socket access failure on TCP-only DOCKER_HOST) was fixed and closed July 10, 2026. The guide's stale limitation and workaround caused operators to apply unnecessary config.

Changes

  • Known limitations — removed the MCP gateway Docker socket bullet; only the allowPrivilegeEscalation: false constraint (still valid) remains.
  • Troubleshooting — removed the Docker daemon is not accessible in MCP gateway section and its shared-volume YAML workaround.

Copilot AI and others added 2 commits July 16, 2026 16:32
…om ARC/DinD guide

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…inD guide

Closes #46042

- Remove MCP gateway Docker socket access bullet from Known limitations
  (issue #44251 was fixed and closed July 10, 2026)
- Remove 'Docker daemon is not accessible' troubleshooting section
  and its YAML snippet workaround
- Keep allowPrivilegeEscalation: false limitation (still accurate)

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot AI changed the title [WIP] Update ARC/DinD guide to reflect resolved MCP gateway limitation docs: remove resolved MCP gateway Docker socket limitation from ARC/DinD guide Jul 16, 2026
Copilot finished work on behalf of lpcox July 16, 2026 16:33
Copilot AI requested a review from lpcox July 16, 2026 16:33
@lpcox

lpcox commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

@copilot reread #46042 and take a look at this issue #46046. then make sure your changes are aligned

…ific, reference #46046

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot reread #46042 and take a look at this issue #46046. then make sure your changes are aligned

Updated in the latest commit. The allowPrivilegeEscalation: false bullet now:

  • Names install_copilot_cli.sh specifically and the exact operations that use sudo (/usr/local/bin install + file ownership)
  • Notes that AWF itself already supports rootless installation — the constraint is Copilot CLI-specific
  • Links to #46046 for rootless Copilot CLI installation tracking

@github-actions

Copy link
Copy Markdown
Contributor

Great cleanup on the ARC/DinD guide! Removing the stale Docker socket limitation and its workaround now that issue #44251 is resolved keeps operators from applying unnecessary config — exactly the kind of housekeeping that makes docs trustworthy. The PR is well-scoped, the description clearly explains what changed and why, and the lock file updates alongside the doc edit are consistent with the repo workflow. No issues to flag — this looks ready for review.

Generated by ✅ Contribution Check · 115.5 AIC · ⌖ 11.1 AIC · ⊞ 6.2K ·

@lpcox
lpcox marked this pull request as ready for review July 16, 2026 18:14
Copilot AI review requested due to automatic review settings July 16, 2026 18:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes obsolete MCP gateway guidance from the ARC/DinD guide while retaining the privilege-escalation limitation.

Changes:

  • Removes resolved Docker socket troubleshooting.
  • Expands Copilot CLI rootless-install guidance.
  • Refreshes generated workflows and changes the auto-upgrade schedule.
Show a summary per file
File Description
docs/src/content/docs/guides/arc-dind-copilot-agent.md Updates ARC/DinD limitations and troubleshooting.
.github/workflows/skillet.lock.yml Refreshes generated action-version metadata.
.github/workflows/release.lock.yml Refreshes generated action-version metadata.
.github/workflows/hourly-ci-cleaner.lock.yml Refreshes generated checkout metadata.
.github/workflows/avenger.lock.yml Refreshes generated checkout metadata.
.github/workflows/agentic-auto-upgrade.yml Changes the weekly execution schedule.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 6/6 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread docs/src/content/docs/guides/arc-dind-copilot-agent.md
Comment thread .github/workflows/agentic-auto-upgrade.yml Outdated
@lpcox

lpcox commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

@copilot run the pr-finisher skill

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #46045 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped. This PR contains only documentation updates.

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot run the pr-finisher skill

Completed a PR-finisher pass and pushed b6bd433 with the requested follow-up fixes; current state and hand-off are summarized in the latest update.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /grill-with-docs — docs-only change removing a resolved limitation.

📋 Key Themes & Highlights

Key Themes

  • Correct removal: The MCP gateway Docker socket section and its YAML workaround are cleanly excised now that #44251 is resolved.
  • Enhanced surviving bullet: The allowPrivilegeEscalation: false entry now explains why the constraint exists, names the script, install path, and links the tracking issue — genuinely more useful than the original.

Minor observation

The new bullet adds implementation details (install_copilot_cli.sh, /usr/local/bin, "fix file ownership") that could drift if the install script changes. Keeping those details is a trade-off worth watching, but not a blocker.

Positive Highlights

  • ✅ Concise removal — no orphan references or broken links left behind
  • ✅ PR description explains the why (issue closed, stale workaround causing unnecessary operator work)
  • ✅ Lock file and schedule changes are unrelated noise; core doc change is surgical

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 18.1 AIC · ⌖ 4.36 AIC · ⊞ 6.7K
Comment /matt to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are accurate and well-scoped: the resolved MCP gateway Docker socket limitation is cleanly removed, the minimum version is correctly bumped to v0.82.8, and the expanded allowPrivilegeEscalation note adds useful context with a tracking issue link. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · 12.5 AIC · ⌖ 4.92 AIC · ⊞ 5K

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues need resolution before merge

The lock-file comment normalization is consistent and correct. The docs removal of the resolved MCP gateway limitation is appropriate. However, two issues block this PR:

Blocking issues

1. Unexplained schedule driftagentic-auto-upgrade.yml silently shifts the cron from Friday 03:21 UTC to Saturday 04:11 UTC with no rationale. This is an operational change hidden in a docs-only PR. Revert or document why the schedule moved.

2. Stale minimum version — The guide still advertises gh-aw ≥ v0.82.5, but the Docker socket fix (which this PR removes the workaround for) shipped in v0.82.8. Users on v0.82.5–v0.82.7 will encounter the failure silently. Update the minimum version to v0.82.8.

🔎 Code quality review by PR Code Quality Reviewer · 69.8 AIC · ⌖ 4.36 AIC · ⊞ 5.6K
Comment /review to run again

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot finished work on behalf of lpcox July 16, 2026 19:54
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, investigate the failed checks listed on this PR if applicable, and rerun checks once the branch is ready.

Generated by 👨‍🍳 PR Sous Chef · 8.18 AIC · ⌖ 7.29 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI and others added 2 commits July 16, 2026 21:44
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address any unresolved review feedback, investigate the failed checks listed on this PR if applicable, and rerun checks once the branch is ready.

...

Completed another pr-finisher pass and pushed aa9ed86, which removes the remaining unrelated workflow/lockfile drift (including the auto-upgrade cron change) so this PR is docs-only again. I checked unresolved review feedback and the remaining open thread is already addressed in-code (gh-aw minimum set to v0.82.8 with upgrade/recompile guidance). I also investigated current PR workflow runs: there are no failed jobs to fix on the latest visible runs (action_required runs report 0 jobs / 0 failures). I can’t re-run checks from this cloud-agent path; a maintainer-triggered rerun is still needed.

Copilot AI requested a review from gh-aw-bot July 16, 2026 22:04
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, resolve the remaining unresolved review thread, and rerun checks once the branch is ready.

Unresolved review threads:

The thread already has a follow-up reply from the PR author, so please confirm the branch state on current HEAD and close out any remaining review cleanup.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/29560675416

Generated by 👨‍🍳 PR Sous Chef · 7.25 AIC · ⌖ 6.05 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
pelikhan and others added 2 commits July 17, 2026 09:00
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, resolve the remaining unresolved review thread, and rerun checks once the branch is ready.

Unresolved review threads:...

Done. I ran another pr-finisher pass and pushed 9d65b7e to remove an unintended /.github/workflows/release.lock.yml drift so the PR is back to docs-only on current HEAD. I confirmed the cited review thread (discussion_r3597930424) is resolved. I also checked current branch workflows and logs: the latest Doc Build - Deploy run (29561928194) is action_required with 0 jobs and 0 failed jobs. I can’t re-run checks from this cloud-agent path; a maintainer re-trigger is still required.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage

Field Value
Category docs
Risk low
Score 33/100 (impact:8, urgency:10, quality:15)
Action auto_merge

Rationale: Removes stale MCP gateway Docker socket limitation from ARC/DinD guide — issue #44251 was fixed July 10. GHA approved. Low risk doc update.

Generated by 🔧 PR Triage Agent · 166.4 AIC · ⌖ 6.15 AIC · ⊞ 5.6K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ARC/DinD guide: remove resolved MCP gateway Docker socket limitation

5 participants