Skip to content

fix(app): refuse a blocked teammate's @ace instead of posting a dead mention #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 2 commits into from
Oct 22, 2026
Merged

fix(app): refuse a blocked teammate's @ace instead of posting a dead mention #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3519ce6
fix(app): refuse a blocked teammate's @ace instead of posting a dead …
iamnbutler Oct 22, 2026
1abbe8d
chore: lane context
iamnbutler Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...app/src/composer.tsx/01M4YQG7BVWEFZPD56A2BA0VE9-mode-ace-mode-channels-id-an.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: function Composer
created: 2026-10-15T02:50:44Z
norm: '1'
sig: 6e0e6c5c8afbd01a
body_hash: 5d41556386df9599
raw_hash: da6fdc606e9e685b
vouched: 2026-10-22T15:31:22Z
body_hash: 50b1bf8d25d5e6da
raw_hash: fcc5ab24dfd60256
vouched: 2026-10-22T17:49:27Z
lines: 99-282
---

Expand Down
6 changes: 3 additions & 3 deletions ...app/src/composer.tsx/01M4ZSEZBJJ3AMEBTR7SH36FW4-models-are-read-only-while-t.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: function Composer
created: 2026-10-15T12:44:15Z
norm: '1'
sig: 6e0e6c5c8afbd01a
body_hash: 5d41556386df9599
raw_hash: da6fdc606e9e685b
vouched: 2026-10-22T15:31:22Z
body_hash: 50b1bf8d25d5e6da
raw_hash: fcc5ab24dfd60256
vouched: 2026-10-22T17:49:27Z
lines: 101-290
---

Expand Down
6 changes: 3 additions & 3 deletions .../app/src/composer.tsx/01M4ZYQVGB6C87WBEV12WPQ8PF-a-withdrawn-message-returns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: function Composer
created: 2026-10-15T14:16:28Z
norm: '1'
sig: 6e0e6c5c8afbd01a
body_hash: 5d41556386df9599
raw_hash: da6fdc606e9e685b
vouched: 2026-10-22T15:31:22Z
body_hash: 50b1bf8d25d5e6da
raw_hash: fcc5ab24dfd60256
vouched: 2026-10-22T17:49:27Z
lines: 104-326
---

Expand Down
15 changes: 13 additions & 2 deletions apps/app/src/composer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ const MODES = [
ACE_MODE,
];
// A teammate the owner hasn't let invoke sees no @ace; the stored mode brings it back with access.
const BLOCKED_MODES = [{ id: "chat", name: "Chat", placeholder: "Message the channel" }];
const BLOCKED_MODES = [{
id: "chat",
name: "Chat",
placeholder: "Message the channel (agent access is off)",
}];
const ACE_MENTION = { name: "ace", avatar: aceAvatar };
export const EFFORTS: Record<Effort, string> = {
off: "Off",
Expand Down Expand Up @@ -241,7 +245,14 @@ export function Composer(

async function send(text: string, mode: string, attached: Attachment[]) {
if (sending.current) return;
// A blocked teammate's typed "@ace" is just text.
// Posted, a blocked teammate's "@ace" would read as an ask nobody answers.
if (blocked && ACE.test(text)) {
toast.error("Agent access is off", {
description:
"The owner hasn't let teammates ask this channel's agent. Remove @ace to send this as a message.",
});
return;
}
const invoke = !blocked && (mode === "ace" || ACE.test(text));
const body = text.trim();
if (!body && !attached.length) return;
Expand Down