Skip to content

fix(app): refuse a blocked teammate's @ace instead of posting a dead mention - #612

Merged
iamnbutler merged 2 commits into
mainfrom
ace-off
Oct 22, 2026
Merged

iamnbutler merged 2 commits into
mainfrom
ace-off

Conversation

@iamnbutler

Copy link
Copy Markdown
Contributor

Fixes #600. In a teammate's channel with agent access off, a typed "@ace …" posted as a green "ace" mention and nobody was told the agent wouldn't answer.

  • Send now refuses a blocked teammate's draft that mentions @ace, with the toast "Agent access is off: The owner hasn't let teammates ask this channel's agent. Remove @ace to send this as a message." The draft stays in the composer, so nothing posts that looks like an ask.
  • The blocked composer's placeholder reads "Message the channel (agent access is off)", so the state shows before anyone types.

The channel already refuses a blocked teammate's ask ("Only the owner can invoke agents here"). This fix stops the client from posting the same words as a say that reads like an ask.

Smoke: isolated loopback host on port 4771 from this lane, rebuilt app. I created the channel with ACE_USER=sam, so the browser's user is a teammate there, and agent access is off by default. The placeholder showed "Message the channel (agent access is off)". I typed "@ace what branch is this?" and pressed Enter. The toast appeared, the draft stayed, and nothing posted. Not covered: the owner still gets no notice when access is turned on or off (also in #600).

Built in Ace

No. Built by Claude Code as a fix worker after the two-Mac pair study because the worker runs outside an Ace channel. Dogfooding gap tracked in #5.

@iamnbutler
iamnbutler merged commit 5caaeea into main Oct 22, 2026
1 check passed
@iamnbutler
iamnbutler deleted the ace-off branch October 22, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@ace from a teammate without agent access posts as a mention and is silently ignored

1 participant