Repository navigation
fix(app): offer agent mode in a teammate's channel only once access is known to be on - #613
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #607. In a teammate's channel whose Mac was offline, the composer offered Ace mode and pre-filled an "ace" chip while agent access was unknown.
The composer now offers agent mode only to the channel's owner, or to a teammate once the channel reports that agent access is on. While access is unknown, it shows Chat only, with the placeholder "Message the channel" and no ace mention. The saved per-channel mode is unchanged, so the person's choice comes back once access is known. Known-off keeps "Message the channel (agent access is off)" from #612.
The study's "reverts to Ace mode after reload" isn't changed here. The mode is already saved per channel in localStorage, and each tester turn used a fresh browser.
Smoke: isolated loopback host on port 4771 from this lane, rebuilt app, with
samchancreated asACE_USER=samso the browser is a teammate there.ace agents samchan on: Ace mode with the ace chip and the model picker.I didn't reproduce this with a real offline second Mac. The frozen worker leaves
sharedunknown in the same way.Built in Ace
No. Built by Claude Code as a fix worker after the two-Mac pair study because the worker runs outside an Ace channel. Dogfooding gap tracked in #5.