Skip to content

fix(app): offer agent mode in a teammate's channel only once access is known to be on #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 2 commits into from
Oct 22, 2026
Merged

fix(app): offer agent mode in a teammate's channel only once access is known to be on #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f278b6
fix(app): offer agent mode in a teammate's channel only once access i…
iamnbutler Oct 22, 2026
5c166a1
chore: lane context
iamnbutler Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...app/src/composer.tsx/01M4YQG7BVWEFZPD56A2BA0VE9-mode-ace-mode-channels-id-an.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: function Composer
created: 2026-10-15T02:50:44Z
norm: '1'
sig: 6e0e6c5c8afbd01a
body_hash: 50b1bf8d25d5e6da
raw_hash: fcc5ab24dfd60256
vouched: 2026-10-22T17:49:27Z
body_hash: 7a4597684360db67
raw_hash: 52e4e5fdab485c4d
vouched: 2026-10-22T17:52:41Z
lines: 99-282
---

Expand Down
6 changes: 3 additions & 3 deletions ...app/src/composer.tsx/01M4ZSEZBJJ3AMEBTR7SH36FW4-models-are-read-only-while-t.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: function Composer
created: 2026-10-15T12:44:15Z
norm: '1'
sig: 6e0e6c5c8afbd01a
body_hash: 50b1bf8d25d5e6da
raw_hash: fcc5ab24dfd60256
vouched: 2026-10-22T17:49:27Z
body_hash: 7a4597684360db67
raw_hash: 52e4e5fdab485c4d
vouched: 2026-10-22T17:52:41Z
lines: 101-290
---

Expand Down
6 changes: 3 additions & 3 deletions .../app/src/composer.tsx/01M4ZYQVGB6C87WBEV12WPQ8PF-a-withdrawn-message-returns.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: function Composer
created: 2026-10-15T14:16:28Z
norm: '1'
sig: 6e0e6c5c8afbd01a
body_hash: 50b1bf8d25d5e6da
raw_hash: fcc5ab24dfd60256
vouched: 2026-10-22T17:49:27Z
body_hash: 7a4597684360db67
raw_hash: 52e4e5fdab485c4d
vouched: 2026-10-22T17:52:41Z
lines: 104-326
---

Expand Down
9 changes: 6 additions & 3 deletions apps/app/src/composer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const BLOCKED_MODES = [{
name: "Chat",
placeholder: "Message the channel (agent access is off)",
}];
const UNKNOWN_MODES = [{ id: "chat", name: "Chat", placeholder: "Message the channel" }];
const ACE_MENTION = { name: "ace", avatar: aceAvatar };
export const EFFORTS: Record<Effort, string> = {
off: "Off",
Expand Down Expand Up @@ -122,8 +123,10 @@ export function Composer(
const [stored, changeMode] = useLocalStorage(`ace:mode:${scope}`, "ace");
// The channel refuses a blocked teammate's ask, stop, and kill too.
const blocked = shared === false && channel.owner !== user;
const mode = blocked ? "chat" : stored;
const mentions = useMemo(() => blocked ? members : [ACE_MENTION, ...members], [blocked, members]);
// Agent mode only once a teammate's access is known to be on, as it isn't while their Mac is offline.
const agents = channel.owner === user || shared === true;
const mode = agents ? stored : "chat";
const mentions = useMemo(() => agents ? [ACE_MENTION, ...members] : members, [agents, members]);
const [models, setModels] = useState<ModelOption[]>();
const [modelError, setModelError] = useState<string>();
const status = useSyncExternalStore(host.subscribe, () => host.status);
Expand Down Expand Up @@ -349,7 +352,7 @@ export function Composer(
scope={scope}
tools={!phone}
mic
modes={blocked ? BLOCKED_MODES : MODES}
modes={agents ? MODES : blocked ? BLOCKED_MODES : UNKNOWN_MODES}
mode={mode}
onModeChange={changeMode}
mentions={mentions}
Expand Down