Repository navigation
fix: offer a teammate's directory after leaving one instead of Create directory - #658
Merged
Merged
Conversation
… directory Why: apps/host/src/peers.ts#function discover | a host with no directory keeps greeting peers so it learns which directory they name; adopt still never joins after a choice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #636. Map ids: ^106 ^115.
After this Mac left a directory that a teammate's host still serves, the sidebar card used to offer Create directory.
directory.offer), and drops it when the peer goes away or stops naming one.adoptnever joins on its own after a choice.directory.offered(url and host) while this host has no directory.directory-setwith that URL, and Change…, which opens Settings → Team.Checks:
bun types,bun run ci.Not live-tested: the card needs a real teammate host that serves a directory. The only one is another person's Mac, and reaching it from an isolated host would have meant using the real Ace's peer port on this Mac. I stopped that attempt, so the Join and Change paths in this state haven't been run end to end.
Built in Ace
No. This was made from Claude Code as a fix-train worker, outside Ace. Dogfooding gap tracked in #5.