Repository navigation
fix(compute): say workspace, not sandbox, in compute service errors - #666
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloud compute service's errors now call the container the workspace, as docs/terms.md does, instead of "sandbox". The stopped-workspace refusal also names the app's Start compute action instead of the service's
start. These errors reach the app through its Cloud compute refusals andace move --compute.Fixes #437
Map: ^427, ^426 (https://ace-map.iamnbutler.pages.nexthub.sh/channels.html#427)
Smoke: not seen live.
wrangler devfor services/compute would not answer requests locally: it needs Node, which this machine lacks, and under Bun it never served a request. Deploying the team's compute service only for a wording check was out of scope. The change touches only the error strings, and nothing matches on their text (grep -i sandboxacross apps, packages and services).bun typesandbun run cipass.Built in Ace
No. Made from Claude Code (fix-train worker). Dogfooding gaps are tracked in #5.