Skip to content

fix(compute): say workspace, not sandbox, in compute service errors #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 1 commit into from
Oct 22, 2026
Merged

fix(compute): say workspace, not sandbox, in compute service errors #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ces/compute/index.ts/01M4ZP2VMF09R0HHHKC1Y3TF8R-freeze-admission-before-admi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: class Compute
created: 2026-10-15T11:45:12Z
norm: '1'
sig: 3b062341dbce15d0
body_hash: 80a9be7bbf3a91be
raw_hash: ee5350909a33775b
vouched: 2026-10-19T16:56:54Z
body_hash: e4fd467ed7e3def8
raw_hash: 32d39e0ed76a4fff
vouched: 2026-10-22T21:46:57Z
lines: 49-325
---

Expand Down
6 changes: 3 additions & 3 deletions ...ces/compute/index.ts/01M4ZQ5V42TR3DK38BGR08FVCE-the-channel-owner-is-the-ace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: class Compute
created: 2026-10-15T12:04:18Z
norm: '1'
sig: 3b062341dbce15d0
body_hash: 80a9be7bbf3a91be
raw_hash: ee5350909a33775b
vouched: 2026-10-19T16:56:54Z
body_hash: e4fd467ed7e3def8
raw_hash: 32d39e0ed76a4fff
vouched: 2026-10-22T21:46:57Z
lines: 51-331
---

Expand Down
6 changes: 3 additions & 3 deletions ...ces/compute/index.ts/01M4ZR2DGB6JZ0KCPK7K8DM74P-delete-stays-idempotent-each.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ anchor: class Compute
created: 2026-10-15T12:19:54Z
norm: '1'
sig: 3b062341dbce15d0
body_hash: 80a9be7bbf3a91be
raw_hash: ee5350909a33775b
vouched: 2026-10-19T16:56:54Z
body_hash: e4fd467ed7e3def8
raw_hash: 32d39e0ed76a4fff
vouched: 2026-10-22T21:46:58Z
lines: 51-353
---

Expand Down
10 changes: 5 additions & 5 deletions services/compute/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export class Compute extends DurableObject<Env> {
}

async #call(path: string, body?: unknown): Promise<Response> {
if (!this.ctx.container?.running) throw new Error("The sandbox is stopped");
if (!this.ctx.container?.running) throw new Error("The workspace is stopped");
const response = await this.ctx.container.getTcpPort(8080).fetch(`http://container${path}`, {
method: body === undefined ? "GET" : "POST",
body: body === undefined
Expand All @@ -119,7 +119,7 @@ export class Compute extends DurableObject<Env> {
await scheduler.wait(1000);
}
}
throw new Error("Sandbox did not become ready in 120 seconds");
throw new Error("The workspace did not become ready in 120 seconds");
}

async #connect(thaw = true) {
Expand Down Expand Up @@ -198,13 +198,13 @@ export class Compute extends DurableObject<Env> {
if (this.ctx.storage.kv.get("frozen") && !this.ctx.storage.kv.get("ready")) {
await this.ctx.container!.destroy();
} else {
throw new Error("Sandbox is already running; use resize to change its size");
throw new Error("The workspace is already running; resize it to change its size");
}
}
const manifest = this.ctx.storage.kv.get<Manifest>("checkpoint");
if (settings.started && !manifest) {
throw new Error(
"The sandbox was lost without a checkpoint; refusing to create an empty replacement",
"The workspace was lost without a checkpoint; refusing to create an empty replacement",
);
}
await this.#channel("freeze");
Expand Down Expand Up @@ -324,7 +324,7 @@ export class Compute extends DurableObject<Env> {
["exec", "checkpoint", "stop", "resize", "resume"].includes(action)
&& !this.ctx.container!.running
) {
throw new Error("The sandbox is stopped; use start to restore it");
throw new Error("The workspace is stopped; Start compute restores it");
}
switch (action) {
case "resume":
Expand Down