Repository navigation
fix(ui): keep the project picker's Remove × hidden and unclickable until the row is hovered - #669
Merged
Merged
Conversation
…til the row is hovered Why: packages/ui/src/components/session-sidebar/session-sidebar.tsx#function RepoRow | the × takes no pointer events until its row is hovered, so a click that never hovered (opened-by-keyboard first row, synthetic clicks) selects the project instead of opening Remove; Delete/Backspace stays the keyboard path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project picker revealed each row's × whenever the row had focus, so opening the menu by keyboard (or an accessibility press) showed a live × on the first row, and the invisible × still took clicks. Now the × takes no pointer events and stays hidden until the pointer is over its row; a click that never hovered selects the project. Keyboard users still remove with Delete/Backspace on the row.
Fixes #616 (the confirmation wording landed in #647; this is the rest).
Map: ^348 (https://ace-map.iamnbutler.pages.nexthub.sh/projects.html#348)
Smoke: own
ace serve --loopback(isolated ACE_HOME, port 4166) with two projects. Opening the picker by keyboard: both × buttons at opacity 0, pointer-events none, and the point under each × hit the row. After hovering the first row: its × at opacity 1 and hit; clicking it opened the Remove flow ("proj still has a channel…").Built in Ace
No. Made from Claude Code (fix-train worker), with a headless browser for the smoke, because the fix train runs outside Ace. Gap tracked in the dogfooding meta issue #5.