Skip to content

fix(ui): keep the project picker's Remove × hidden and unclickable until the row is hovered #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 2 commits into from
Oct 22, 2026
Merged

fix(ui): keep the project picker's Remove × hidden and unclickable until the row is hovered #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab7d4c
fix(ui): keep the project picker's Remove × hidden and unclickable un…
iamnbutler Oct 22, 2026
ded1407
lane: sync fix-picker-remove memory
iamnbutler Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...r/session-sidebar.tsx/01M5JTK8PMAS2P823HXPXMFKMR-the-takes-no-pointer-events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
id: 01M5JTK8PMAS2P823HXPXMFKMR
anchor: function RepoRow
created: 2026-10-22T22:09:38Z
norm: '1'
sig: 5bbcb5703dd86c8d
body_hash: 9b1f1cd24e2d657a
raw_hash: 7612fe683d65a653
lines: 204-266
---

the × takes no pointer events until its row is hovered, so a click that never hovered (opened-by-keyboard first row, synthetic clicks) selects the project instead of opening Remove; Delete/Backspace stays the keyboard path
4 changes: 2 additions & 2 deletions packages/ui/src/components/session-sidebar/session-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ function RepoRow({ repo, selected, onRepoChange, onRepoRemove }: {
<RepoName name={repo.name} title={repo.title} />
<span className="relative grid size-5 shrink-0 place-items-center">
{selected && (
<IconCheck className="size-3.5 transition-opacity duration-150 ease-out group-hover/repo:opacity-0 group-focus/repo:opacity-0 group-focus-within/repo:opacity-0" />
<IconCheck className="size-3.5 transition-opacity duration-150 ease-out group-hover/repo:opacity-0" />
)}
{onRepoRemove && (
<Tooltip>
Expand All @@ -240,7 +240,7 @@ function RepoRow({ repo, selected, onRepoChange, onRepoRemove }: {
<button
type="button"
aria-label={`Remove ${repo.name}`}
className="absolute grid size-5 place-items-center rounded-md squircle text-muted-foreground opacity-0 outline-2 outline-offset-[-1px] outline-transparent transition-[background-color,color,opacity,transform] duration-150 ease-out hover:bg-foreground/10 hover:text-foreground focus-visible:bg-foreground/10 focus-visible:text-foreground focus-visible:outline-ring/50 active:translate-y-px group-hover/repo:text-foreground/80 group-hover/repo:opacity-100 group-focus/repo:text-foreground/80 group-focus/repo:opacity-100 group-focus-within/repo:text-foreground/80 group-focus-within/repo:opacity-100"
className="pointer-events-none absolute grid size-5 place-items-center rounded-md squircle text-muted-foreground opacity-0 outline-2 outline-offset-[-1px] outline-transparent transition-[background-color,color,opacity,transform] duration-150 ease-out hover:bg-foreground/10 hover:text-foreground focus-visible:bg-foreground/10 focus-visible:text-foreground focus-visible:outline-ring/50 active:translate-y-px group-hover/repo:text-foreground/80 group-hover/repo:pointer-events-auto group-hover/repo:opacity-100 focus-visible:pointer-events-auto focus-visible:opacity-100"
onPointerDown={(event) => event.stopPropagation()}
onMouseUp={(event) => event.stopPropagation()}
onKeyDown={event => {
Expand Down