Repository navigation
fix(ui): show every reaction's count and keep the emoji search readable - #670
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reaction pills now show their count for one reaction too, as in
👎 1. Before, a pill showed only the emoji until a second person reacted. The emoji picker's search field was black in the light theme, so typed text couldn't be read. emoji-mart takes--rgb-inputwith no alpha, and the light theme's--inputis translucent black (oklch(0 0 0 / 0.10)), which came out as0, 0, 0. The picker now paints--inputover--popoverbefore reading the color.Smoke-tested on a loopback source host (own ACE_HOME, port 4377) in headless Chromium, with a channel and a message posted through
ace say:rgb(224, 223, 220)with textrgb(12, 12, 9), and the typed "thumbs" is readable.rgb(47, 46, 41)with textrgb(251, 251, 249), as before.👎 1pill under the message.Map: ^561. Part of #619: this fixes the pill counts and the emoji search. Still open in #619: a deleted message stays on screen until you switch channels (^559), and the hover toolbar stops appearing after you remove your own reaction (^562).
Built in Ace
No. Claude Code (fix-train worker) made this outside Ace, running against a loopback source host. It used headless Chromium to smoke the web client. Dogfooding gaps are tracked in #5.