Skip to content

fix(gooddata-eval): name the builder skill flag the backend defines - #1879

Merged
romrak merged 1 commit into
masterfrom
rr/LX-3248-flag-hint
Oct 14, 2026
Merged

romrak merged 1 commit into
masterfrom
rr/LX-3248-flag-hint

Conversation

@romrak

@romrak romrak commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The document-skill failure hint now names enableGenAiReportBuilderSkill, the flag gdc-nas and helm actually define. The hint said enableGenAiDocumentBuilderSkill, but no backend defines that flag. The Report flag is removed at GA instead of being renamed.

JIRA: LX-3248

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the feature-flag name shown when the document-builder skill is not enabled.

The failure hint for a document skill that never activated named
enableGenAiDocumentBuilderSkill, which no backend defines. gdc-nas and
helm still ship enableGenAiReportBuilderSkill, and that flag is removed
at GA rather than renamed, so the hint now points at it.

JIRA: LX-3248
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: ae508a8d-b85e-48f1-9eb0-ba6568d73f2a
📥 Commits

Reviewing files that changed from the base of the PR and between 85ce16a and 057c263.

📒 Files selected for processing: 2
  • packages/gooddata-eval/src/gooddata_eval/core/agentic/document_skill.py
  • packages/gooddata-eval/tests/test_agentic_document_skill.py

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The document-builder skill diagnostic now names enableGenAiDocumentBuilderSkill. Two test expectations now refer to enableGenAiReportBuilderSkill.

Changes: Document-builder diagnostic

Layer / File(s) Summary
Correct the diagnostic and test expectations
packages/gooddata-eval/src/gooddata_eval/core/agentic/document_skill.py, packages/gooddata-eval/tests/test_agentic_document_skill.py
The diagnostic names enableGenAiDocumentBuilderSkill. Two test expectations refer to enableGenAiReportBuilderSkill. The organization-level flag requirement is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 057c2

The diagnostic and its test consistently refer to the Report Builder flag. Available backend information does not confirm its activation semantics, but no concrete configuration failure is established.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: updating the builder skill flag name to match the backend definition.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the flags at dawn,
The builder’s name is written on.
The tests now match the words they see,
The brief remains as it should be.
Then off I hop beneath the sun.

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.91%. Comparing base (85ce16a) to head (057c263).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1879   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files         336      336           
  Lines       24072    24072           
=======================================
  Hits        20441    20441           
  Misses       3631     3631           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romrak
romrak merged commit 989bee0 into master Oct 14, 2026
14 checks passed
@romrak
romrak deleted the rr/LX-3248-flag-hint branch October 14, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants