Skip to content

fix(gooddata-eval): name the builder skill flag the backend defines #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romrak merged 1 commit into from
Oct 14, 2026
Merged

fix(gooddata-eval): name the builder skill flag the backend defines #1879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gooddata-eval/src/gooddata_eval/core/agentic/document_skill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,7 @@ def _run_detail(run: DocumentRunResult) -> dict[str, Any]:
elif not best.evaluation.skill_activated:
skill_note = (
f" set_skills never activated {_BUILDER_SKILL}: either the copilot routed elsewhere, or the skill"
" is not registered. It registers only with enableGenAiDocumentBuilderSkill and the org's"
" is not registered. It registers only with enableGenAiReportBuilderSkill and the org's"
" enableBusinessBriefingReportsApp both on."
)
exc = DocumentSkillAssertionError(
Expand Down
4 changes: 2 additions & 2 deletions packages/gooddata-eval/tests/test_agentic_document_skill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ def test_a_failing_item_on_the_report_names_points_at_the_rename_not_the_flags(
evaluate_agentic_document_skill("https://h", "tok", "ws", "Create a document", {}, max_iterations=1)

assert "gen-ai still sends the Report names" in str(raised.value)
assert "enableGenAiDocumentBuilderSkill" not in str(raised.value)
assert "enableGenAiReportBuilderSkill" not in str(raised.value)


def test_a_user_context_with_view_report_fails_before_any_request(monkeypatch: pytest.MonkeyPatch) -> None:
Expand Down Expand Up @@ -669,7 +669,7 @@ def test_a_failing_item_without_document_builder_points_at_the_flags(monkeypatch
_install_client(monkeypatch, _ScriptedChatClient([turn]))
with pytest.raises(
DocumentSkillAssertionError,
match="enableGenAiDocumentBuilderSkill and the org.s enableBusinessBriefingReportsApp",
match="enableGenAiReportBuilderSkill and the org.s enableBusinessBriefingReportsApp",
):
evaluate_agentic_document_skill("https://h", "tok", "ws", "Create a document", {}, max_iterations=1)

Expand Down
Loading