Repository navigation
feat(storage): wire logical operation metrics in Retrying and StorageOptions - #14695
Open
nidhiii-27 wants to merge 4 commits into
Open
nidhiii-27 wants to merge 4 commits into
nidhiii-27 wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates OpenTelemetry metrics into the client-side retry mechanism of Google Cloud Storage. It updates StorageOptions, GrpcStorageOptions, and HttpStorageOptions to expose StorageClientMetrics, and modifies Retrying.DefaultRetrier to record attempts, errors, retries, operations, and duration metrics when metrics are enabled. Additionally, a comprehensive test suite RetryingMetricsTest has been added to verify metric collection across various retry scenarios. There are no review comments, and I have no feedback to provide.
nidhiii-27
added this pull request to stack #14485
October 20, 2026 10:06
nidhiii-27
force-pushed
the
feat/storage-metrics-context-error-mapping
branch
from
October 20, 2026 11:50
608c46a to
1bf9a9d
Compare
nidhiii-27
force-pushed
the
feat/storage-logical-metrics
branch
from
October 20, 2026 12:11
b385679 to
0a3696b
Compare
cpriti-os
requested changes
Oct 20, 2026
nidhiii-27
added a commit
that referenced
this pull request
Oct 20, 2026
…options - Narrow PR #14695 to core Retrying chokepoint and options wiring - Remove per-run StorageMetricsContext binding from DefaultRetrierWithAlg to avoid elapsed time drift across runs - Add createMetricsContext helper on StorageOptions - Revert veneer operation wiring and server address attributes to separate stacked PR - Update unit tests in RetryingMetricsTest [Generated-by: AI]
nidhiii-27
marked this pull request as ready for review
October 22, 2026 05:02
Dhriti07
force-pushed
the
feat/storage-logical-metrics
branch
from
October 22, 2026 05:06
df24cde to
2455496
Compare
nidhiii-27
force-pushed
the
feat/storage-metrics-context-error-mapping
branch
from
October 22, 2026 05:35
98fb508 to
84a5ac6
Compare
nidhiii-27
force-pushed
the
feat/storage-logical-metrics
branch
from
October 22, 2026 05:42
2455496 to
02b170e
Compare
nidhiii-27
removed this pull request from stack #14485
October 22, 2026 05:45
nidhiii-27
changed the base branch from
feat/storage-metrics-context-error-mapping
to
feat/storage-metrics-context
October 22, 2026 05:45
nidhiii-27
changed the title
nidhiii-27
force-pushed
the
feat/storage-metrics-context
branch
from
October 22, 2026 05:54
f943017 to
edb3def
Compare
…Options [Generated-by: AI]
nidhiii-27
force-pushed
the
feat/storage-logical-metrics
branch
from
October 22, 2026 05:54
02b170e to
2b123b7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires client-level metrics lifecycle and retrier operation metrics into StorageOptions and Retrying.
StorageClientMetricsprovider and lifecycle management inStorageOptions.Retryingto record operation attempts, durations, and status attributes.StorageOptionsTest,StorageClientMetricsTest,RetryingMetricsTest).Stacked on #14728.