Repository navigation
feat(storage): wire operation metrics in HTTP veneer and storage channels - #14698
Open
nidhiii-27 wants to merge 4 commits into
Open
nidhiii-27 wants to merge 4 commits into
nidhiii-27 wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates StorageMetricsContext across various storage operations in GrpcStorageImpl, StorageImpl, and GapicCopyWriter to enable operation-specific metrics tracking. However, in GrpcStorageImpl.java's moveBlob method, the metricsContext is passed to the retrier but is not merged into the GrpcCallContext or passed to the moveObjectCallable call, which prevents proper propagation of the metrics context to the gRPC request.
nidhiii-27
added this pull request to stack #14485
October 21, 2026 08:14
Dhriti07
force-pushed
the
feat/storage-veneer-operation-metrics
branch
from
October 22, 2026 05:06
29c672c to
6c828d8
Compare
nidhiii-27
force-pushed
the
feat/storage-logical-metrics
branch
from
October 22, 2026 05:42
2455496 to
02b170e
Compare
nidhiii-27
removed this pull request from stack #14485
October 22, 2026 05:45
nidhiii-27
force-pushed
the
feat/storage-veneer-operation-metrics
branch
from
October 22, 2026 05:47
6c828d8 to
3011be4
Compare
nidhiii-27
changed the title
nidhiii-27
force-pushed
the
feat/storage-logical-metrics
branch
from
October 22, 2026 05:54
02b170e to
2b123b7
Compare
…nels [Generated-by: AI]
nidhiii-27
force-pushed
the
feat/storage-veneer-operation-metrics
branch
from
October 22, 2026 05:55
3011be4 to
261bc60
Compare
…operation-metrics
…operation-metrics
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires operation metrics into shared storage channels and the HTTP/JSON veneer implementation.
StorageMetricsContextintoBaseStorageReadChannelandBaseStorageWriteChannelto record operations on close.StorageImpl,HttpCopyWriter, and HTTP channel wrappers (BlobReadChannelV2,BlobWriteChannelV2).CopyWriterTestunit tests.Stacked on #14695.