Skip to content

test(issuance): port RewardsManager interface and config tests to Foundry - #1381

Merged
Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5a-rewards-config
Oct 29, 2026
Merged

Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5a-rewards-config

Conversation

@Maikol

@Maikol Maikol commented Oct 26, 2026

Copy link
Copy Markdown
Member

Adds a Foundry test base in @graphprotocol/issuance that deploys the existing 0.7.6 RewardsManager from the @graphprotocol/contracts build output with mock curation, rewards issuer, issuance allocator and eligibility oracle, ports the interface and configuration tests onto it, and deletes the TypeScript tests they replace. The remaining RewardsManager tests move onto the same base in the next PRs. Stacked on #1380.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.02%. Comparing base (00c080e) to head (3b2a00a).
⚠️ Report is 2 commits behind head on chore/contracts-removal-phase-0.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           chore/contracts-removal-phase-0    #1381      +/-   ##
===================================================================
- Coverage                            83.17%   83.02%   -0.16%     
===================================================================
  Files                                   81       81              
  Lines                                 5326     5326              
  Branches                               973      973              
===================================================================
- Hits                                  4430     4422       -8     
- Misses                                 875      883       +8     
  Partials                                21       21              
Flag Coverage Δ
unittests 83.02% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Maikol
Maikol force-pushed the test/contracts-removal-t4-epochs branch from c2a0aa9 to ec87a86 Compare October 29, 2026 17:34
@Maikol
Maikol force-pushed the test/contracts-removal-t5a-rewards-config branch from c9a4eb0 to 005d61b Compare October 29, 2026 17:34
@Maikol
Maikol force-pushed the test/contracts-removal-t4-epochs branch from ec87a86 to dc5bfb3 Compare October 29, 2026 18:42
@Maikol
Maikol force-pushed the test/contracts-removal-t5a-rewards-config branch from 005d61b to 4c47115 Compare October 29, 2026 18:42
@Maikol
Maikol force-pushed the test/contracts-removal-t5a-rewards-config branch from 4c47115 to 3b2a00a Compare October 29, 2026 18:48
@Maikol
Maikol force-pushed the test/contracts-removal-t4-epochs branch from dc5bfb3 to 00c080e Compare October 29, 2026 18:48
@Maikol
Maikol changed the base branch from test/contracts-removal-t4-epochs to chore/contracts-removal-phase-0 October 29, 2026 19:52
@Maikol
Maikol merged commit 3b2a00a into chore/contracts-removal-phase-0 Oct 29, 2026
6 checks passed
@Maikol
Maikol deleted the test/contracts-removal-t5a-rewards-config branch October 29, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant