Skip to content

test(issuance): port RewardsManager calculations and distribution tests to Foundry - #1382

Merged
Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5b-rewards-distribution
Oct 29, 2026
Merged

Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5b-rewards-distribution

Conversation

@Maikol

@Maikol Maikol commented Oct 26, 2026

Copy link
Copy Markdown
Member

Ports the RewardsManager reward calculation and distribution tests to Foundry on the issuance test base, and deletes the TypeScript tests they replace. Two old assertions compared values that rounded to the same number and could never fail; the ports assert the exact values the contract produces, including 125 GRT per block for the query-fee case. For the three cases that went through legacy Staking, only the RewardsManager assertions are kept. Stacked on #1381.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.02%. Comparing base (3b2a00a) to head (47f8a8a).
⚠️ Report is 3 commits behind head on chore/contracts-removal-phase-0.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           chore/contracts-removal-phase-0    #1382    +/-   ##
=================================================================
  Coverage                            83.02%   83.02%            
=================================================================
  Files                                   81       81            
  Lines                                 5326     5326            
  Branches                               973     1132   +159     
=================================================================
  Hits                                  4422     4422            
  Misses                                 883      883            
  Partials                                21       21            
Flag Coverage Δ
unittests 83.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Maikol
Maikol force-pushed the test/contracts-removal-t5b-rewards-distribution branch from 0ae63cb to 1ef148a Compare October 29, 2026 17:34
@Maikol
Maikol force-pushed the test/contracts-removal-t5a-rewards-config branch from c9a4eb0 to 005d61b Compare October 29, 2026 17:34
@Maikol
Maikol force-pushed the test/contracts-removal-t5b-rewards-distribution branch from 1ef148a to 42e1835 Compare October 29, 2026 18:42
@Maikol
Maikol force-pushed the test/contracts-removal-t5a-rewards-config branch from 005d61b to 4c47115 Compare October 29, 2026 18:42
@Maikol
Maikol force-pushed the test/contracts-removal-t5b-rewards-distribution branch from 42e1835 to 1cd1805 Compare October 29, 2026 18:48
@Maikol
Maikol force-pushed the test/contracts-removal-t5a-rewards-config branch from 4c47115 to 3b2a00a Compare October 29, 2026 18:48
@Maikol
Maikol changed the base branch from test/contracts-removal-t5a-rewards-config to chore/contracts-removal-phase-0 October 29, 2026 19:56
@Maikol
Maikol force-pushed the test/contracts-removal-t5b-rewards-distribution branch from 1cd1805 to 47f8a8a Compare October 29, 2026 20:07
@Maikol
Maikol merged commit 47f8a8a into chore/contracts-removal-phase-0 Oct 29, 2026
2 checks passed
@Maikol
Maikol deleted the test/contracts-removal-t5b-rewards-distribution branch October 29, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant