Repository navigation
test(issuance): port RewardsManager calculations and distribution tests to Foundry - #1382
Merged
Maikol merged 1 commit intoOct 29, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/contracts-removal-phase-0 #1382 +/- ##
=================================================================
Coverage 83.02% 83.02%
=================================================================
Files 81 81
Lines 5326 5326
Branches 973 1132 +159
=================================================================
Hits 4422 4422
Misses 883 883
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Maikol
force-pushed
the
test/contracts-removal-t5b-rewards-distribution
branch
from
October 29, 2026 17:34
0ae63cb to
1ef148a
Compare
Maikol
force-pushed
the
test/contracts-removal-t5a-rewards-config
branch
from
October 29, 2026 17:34
c9a4eb0 to
005d61b
Compare
Maikol
force-pushed
the
test/contracts-removal-t5b-rewards-distribution
branch
from
October 29, 2026 18:42
1ef148a to
42e1835
Compare
Maikol
force-pushed
the
test/contracts-removal-t5a-rewards-config
branch
from
October 29, 2026 18:42
005d61b to
4c47115
Compare
Maikol
force-pushed
the
test/contracts-removal-t5b-rewards-distribution
branch
from
October 29, 2026 18:48
42e1835 to
1cd1805
Compare
Maikol
force-pushed
the
test/contracts-removal-t5a-rewards-config
branch
from
October 29, 2026 18:48
4c47115 to
3b2a00a
Compare
Maikol
changed the base branch from
test/contracts-removal-t5a-rewards-config
to
chore/contracts-removal-phase-0
October 29, 2026 19:56
Maikol
force-pushed
the
test/contracts-removal-t5b-rewards-distribution
branch
from
October 29, 2026 20:07
1cd1805 to
47f8a8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the RewardsManager reward calculation and distribution tests to Foundry on the issuance test base, and deletes the TypeScript tests they replace. Two old assertions compared values that rounded to the same number and could never fail; the ports assert the exact values the contract produces, including 125 GRT per block for the query-fee case. For the three cases that went through legacy Staking, only the RewardsManager assertions are kept. Stacked on #1381.