Skip to content

test(issuance): port RewardsManager allocator and subgraph service tests - #1383

Merged
Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5c-rewards-issuers
Oct 29, 2026
Merged

Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5c-rewards-issuers

Conversation

@Maikol

@Maikol Maikol commented Oct 26, 2026

Copy link
Copy Markdown
Member

Ports the RewardsManager tests for the issuance allocator and for the subgraph service as rewards issuer to Foundry on the issuance test base, and deletes the TypeScript tests they replace. The old cases that mixed allocations from staking and the subgraph service now run against the single rewards issuer, since only one exists. Stacked on #1382.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.74%. Comparing base (47f8a8a) to head (7dbe58a).
⚠️ Report is 2 commits behind head on chore/contracts-removal-phase-0.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           chore/contracts-removal-phase-0    #1383      +/-   ##
===================================================================
- Coverage                            83.02%   82.74%   -0.29%     
===================================================================
  Files                                   81       81              
  Lines                                 5326     5326              
  Branches                              1132     1132              
===================================================================
- Hits                                  4422     4407      -15     
- Misses                                 883      897      +14     
- Partials                                21       22       +1     
Flag Coverage Δ
unittests 82.74% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Maikol
Maikol force-pushed the test/contracts-removal-t5c-rewards-issuers branch from 732f9fc to 9e18ee9 Compare October 29, 2026 17:34
@Maikol
Maikol force-pushed the test/contracts-removal-t5b-rewards-distribution branch 2 times, most recently from 1ef148a to 42e1835 Compare October 29, 2026 18:42
@Maikol
Maikol force-pushed the test/contracts-removal-t5c-rewards-issuers branch from 9e18ee9 to 1577e43 Compare October 29, 2026 18:42
@Maikol
Maikol force-pushed the test/contracts-removal-t5b-rewards-distribution branch from 42e1835 to 1cd1805 Compare October 29, 2026 18:48
@Maikol
Maikol force-pushed the test/contracts-removal-t5c-rewards-issuers branch from 1577e43 to 4b4f6e2 Compare October 29, 2026 18:48
@Maikol
Maikol force-pushed the test/contracts-removal-t5b-rewards-distribution branch from 1cd1805 to 47f8a8a Compare October 29, 2026 20:07
@Maikol
Maikol force-pushed the test/contracts-removal-t5c-rewards-issuers branch from 4b4f6e2 to 7dbe58a Compare October 29, 2026 20:07
@Maikol
Maikol changed the base branch from test/contracts-removal-t5b-rewards-distribution to chore/contracts-removal-phase-0 October 29, 2026 20:14
@Maikol
Maikol merged commit 7dbe58a into chore/contracts-removal-phase-0 Oct 29, 2026
4 checks passed
@Maikol
Maikol deleted the test/contracts-removal-t5c-rewards-issuers branch October 29, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant