Repository navigation
fix(cli): carry rounded-up seconds and kilobytes into the next unit - #5817
Open
rudycelekli wants to merge 2 commits into
Open
rudycelekli wants to merge 2 commits into
rudycelekli wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 of 5 tasks
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
formatDurationandformatBytesinpackages/cli/src/ui/format.tsprint an out-of-range value when rounding reaches the next unit.Why
formatDuration(59_960)prints60.0s, andformatDuration(119_970)prints1m 60.0s. The seconds part is rounded after the minute split, so it can reach 60.formatBytes(1_048_575)prints1024.0 KBinstead of1.0 MB.These feed
hyperframes cloud renderprogress and upload lines,infosize, and Chrome download progress.Related work
No overlapping PR found.
How
Round
formatDurationto tenths of a second before splitting into minutes and seconds. Round the KB value before comparing it with the MB threshold. Output for all other inputs is unchanged.Test plan
mainand pass with the fix (vitest run src/ui/format.test.ts, 26 tests).oxfmt --checkandoxlintclean on the changed files.Not run locally: workspace typecheck, comment citation/ratchet scripts (they failed to start in my minimal install).