Skip to content

Fix build-SITL-Mac VLA-folding-constant error in log.c #11679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sensei-hacker merged 2 commits into from
Jul 2, 2026
+7 −3
Merged

Fix build-SITL-Mac VLA-folding-constant error in log.c #11679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce2876f
Fix build-SITL-Mac VLA-folding-constant error in log.c
sensei-hacker Jul 2, 2026
b13c96a
Fix build-SITL-Mac VLA-folding-constant error in osd.c STATIC_ASSERT
sensei-hacker Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/common/log.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,12 @@ void _logBufferHex(logTopic_e topic, unsigned level, const void *buffer, size_t
{
// Print lines of up to maxBytes bytes. We need 5 characters per byte
// 0xAB[space|\n]
const size_t charsPerByte = 5;
const size_t maxBytes = 8;
// charsPerByte/maxBytes must be true compile-time constants (not `const`
// locals) so the buffer size below is a real constant expression, not a VLA.
enum {
charsPerByte = 5,
maxBytes = 8,
};
char buf[LOG_PREFIX_FORMATTED_SIZE + charsPerByte * maxBytes + 1]; // +1 for the null terminator
size_t bufPos = LOG_PREFIX_FORMATTED_SIZE;
const uint8_t *inputPtr = buffer;
Expand Down
2 changes: 1 addition & 1 deletion src/main/io/osd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ static void osdFormatCoordinate(char *buff, char sym, int32_t val)
int integerDigits = tfp_sprintf(buff + 1, (integerPart == 0 && val < 0) ? "-%d" : "%d", (int)integerPart);
// We can show up to 7 digits in decimalPart.
int32_t decimalPart = abs(val % (int)GPS_DEGREES_DIVIDER);
STATIC_ASSERT(GPS_DEGREES_DIVIDER == 1e7, adjust_max_decimal_digits);
STATIC_ASSERT(GPS_DEGREES_DIVIDER == 10000000L, adjust_max_decimal_digits);
int decimalDigits;
bool djiCompat = false; // Assume DJICOMPAT mode is no enabled

Expand Down
Loading