Skip to content

Pass github.base_ref to the changelog check through env #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turegjorup merged 1 commit into from
Oct 5, 2026
Merged

Pass github.base_ref to the changelog check through env #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Changelog", this file is a reverse-chronological list of merged pull requests.

## Open PR's

- [PR-154](https://github.com/itk-dev/devops_itkdev-docker/pull/154) - 2026-10-05 -
Pass `github.base_ref` to the changelog workflow through `env` instead of
interpolating it into the shell command
- [PR-153](https://github.com/itk-dev/devops_itkdev-docker/pull/153) - 2026-09-29 -
Added basic template for python base projects
- [PR-152](https://github.com/itk-dev/devops_itkdev-docker/pull/152) - 2026-09-15 -
Expand Down
4 changes: 3 additions & 1 deletion github/workflows/changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ jobs:
run: git fetch

- name: Check that changelog has been updated.
run: git diff --exit-code origin/${{ github.base_ref }} -- CHANGELOG.md && exit 1 || exit 0
env:
BASE_REF: ${{ github.base_ref }}
run: git diff --exit-code "origin/$BASE_REF" -- CHANGELOG.md && exit 1 || exit 0
4 changes: 3 additions & 1 deletion templates/python/.github/workflows/changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ jobs:
run: git fetch

- name: Check that changelog has been updated.
run: git diff --exit-code origin/${{ github.base_ref }} -- CHANGELOG.md && exit 1 || exit 0
env:
BASE_REF: ${{ github.base_ref }}
run: git diff --exit-code "origin/$BASE_REF" -- CHANGELOG.md && exit 1 || exit 0
Loading