Repository navigation
Pass github.base_ref to the changelog check through env - #154
Merged
Merged
Conversation
cableman
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog workflow interpolated
${{ github.base_ref }}straight into therun:shell command; it now goes throughenvand is quoted.Changes
github/workflows/changelog.yaml(linked into the Drupal and Symfony templates) andtemplates/python/.github/workflows/changelog.yaml:BASE_REFinenv,"origin/$BASE_REF"in the commandWhy
GitHub recommends passing expression values to scripts through environment variables rather than interpolating them, so the shell never parses them as code (Security hardening for GitHub Actions). The risk is low here, since
base_refis a branch in the target repository, but the safe form costs two lines. Found while adopting the Python template in itk-devops/itk-server-harvest#32.