Skip to content

Copy the server name instead of an ssh link - #153

Merged
turegjorup merged 3 commits into
developfrom
feature/copy-server-name
Sep 30, 2026
Merged

turegjorup merged 3 commits into
developfrom
feature/copy-server-name

Conversation

@turegjorup

Copy link
Copy Markdown
Contributor

Link to ticket

TODO: no ticket linked yet — please add before review.

Description

Replace the ssh:// badge next to the server name, which browsers don't open, with a copy button like GitHub's.

  • The server name field shows a copy icon. Clicking it copies the name to the clipboard and shows a check mark for two seconds; the tooltip reads "Copy name". On the list it sits at the right edge of the column as before, on the detail page right after the name.
  • The admin JS and CSS now load as one admin Webpack Encore entry from DashboardController::configureAssets(), so they reach every admin page (EasyAdmin docs). Before, the CSS-only admin entry came from the dashboard and the JS easyadmin entry only from AbstractFullCrudController. assets/easyadmin.js is now assets/admin.js and imports styles/app.css.
  • The field template is renamed from ssh_link.html.twig to copy_text.html.twig.

styles/app.css keeps its name for now: the leftover AssetMapper assets/app.js imports it, and EasyAdmin renders importmap() on every admin page, so renaming it breaks every admin page. The move from Webpack Encore to Symfony Reprise follows in a separate PR, which also removes AssetMapper.

Screenshot

TODO: copy icon next to the server name.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@turegjorup turegjorup self-assigned this Sep 30, 2026
@github-actions

Copy link
Copy Markdown

API Specification - Non-breaking changes

No changelog changes

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.55%. Comparing base (367bf43) to head (644f875).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #153      +/-   ##
=============================================
- Coverage      64.58%   64.55%   -0.03%     
+ Complexity      1270     1269       -1     
=============================================
  Files            167      167              
  Lines           3942     3939       -3     
=============================================
- Hits            2546     2543       -3     
  Misses          1396     1396              
Flag Coverage Δ
unittests 64.55% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turegjorup
turegjorup merged commit a5452a2 into develop Sep 30, 2026
16 checks passed
@turegjorup
turegjorup deleted the feature/copy-server-name branch September 30, 2026 21:28
@turegjorup turegjorup mentioned this pull request Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants