Repository navigation
Copy the server name instead of an ssh link - #153
Merged
Merged
Conversation
API Specification - Non-breaking changesNo changelog changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #153 +/- ##
=============================================
- Coverage 64.58% 64.55% -0.03%
+ Complexity 1270 1269 -1
=============================================
Files 167 167
Lines 3942 3939 -3
=============================================
- Hits 2546 2543 -3
Misses 1396 1396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
TODO: no ticket linked yet — please add before review.
Description
Replace the
ssh://badge next to the server name, which browsers don't open, with a copy button like GitHub's.adminWebpack Encore entry fromDashboardController::configureAssets(), so they reach every admin page (EasyAdmin docs). Before, the CSS-onlyadminentry came from the dashboard and the JSeasyadminentry only fromAbstractFullCrudController.assets/easyadmin.jsis nowassets/admin.jsand importsstyles/app.css.ssh_link.html.twigtocopy_text.html.twig.styles/app.csskeeps its name for now: the leftover AssetMapperassets/app.jsimports it, and EasyAdmin rendersimportmap()on every admin page, so renaming it breaks every admin page. The move from Webpack Encore to Symfony Reprise follows in a separate PR, which also removes AssetMapper.Screenshot
TODO: copy icon next to the server name.
Checklist