Repository navigation
fix: show harvester errors as readable messages - #174
Merged
Merged
Conversation
API Specification - Non-breaking changesNo changelog changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #174 +/- ##
=============================================
+ Coverage 69.27% 76.96% +7.68%
- Complexity 1300 1352 +52
=============================================
Files 168 172 +4
Lines 3987 4145 +158
=============================================
+ Hits 2762 3190 +428
+ Misses 1225 955 -270
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/8363
Description
Show detection result errors and warnings as readable messages instead of JSON.
Changes:
harvester_messages.html.twigfield template: per item the source, container and exit code, the command, and the message in a wrapping<pre>with its line breaks. "None" when empty.DetectionResultCrudControlleruses it forerrorsandwarnings;getPrettyErrors()andgetPrettyWarnings()are removed.AdminSmokeTestchecks a multi-line Composer error renders in full.Why: the JSON view kept the message on one line with escaped
\n, and the code block cut it off. A Composer error from deltag on staging was unreadable past its first line.Checklist