Skip to content

fix: show harvester errors as readable messages - #174

Merged
turegjorup merged 2 commits into
developfrom
feature/8363-envelope-display
Nov 4, 2026
Merged

turegjorup merged 2 commits into
developfrom
feature/8363-envelope-display

Conversation

@turegjorup

Copy link
Copy Markdown
Contributor

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/8363

Description

Show detection result errors and warnings as readable messages instead of JSON.

Changes:

  • New harvester_messages.html.twig field template: per item the source, container and exit code, the command, and the message in a wrapping <pre> with its line breaks. "None" when empty.
  • DetectionResultCrudController uses it for errors and warnings; getPrettyErrors() and getPrettyWarnings() are removed.
  • AdminSmokeTest checks a multi-line Composer error renders in full.

Why: the JSON view kept the message on one line with escaped \n, and the code block cut it off. A Composer error from deltag on staging was unreadable past its first line.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@turegjorup turegjorup self-assigned this Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

API Specification - Non-breaking changes

No changelog changes

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (12fc5ac) to head (6815205).
⚠️ Report is 33 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #174      +/-   ##
=============================================
+ Coverage      69.27%   76.96%   +7.68%     
- Complexity      1300     1352      +52     
=============================================
  Files            168      172       +4     
  Lines           3987     4145     +158     
=============================================
+ Hits            2762     3190     +428     
+ Misses          1225      955     -270     
Flag Coverage Δ
unittests 76.96% <100.00%> (+7.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turegjorup
turegjorup merged commit 844d85e into develop Nov 4, 2026
15 checks passed
@turegjorup
turegjorup deleted the feature/8363-envelope-display branch November 4, 2026 22:06
@turegjorup turegjorup mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants