Repository navigation
fix: store long advisories and mark skipped ones on results - #175
Merged
Merged
Conversation
# Conflicts: # CHANGELOG.md # src/Controller/Admin/DetectionResultCrudController.php # src/Entity/DetectionResult.php
API Specification - Non-breaking changesNo changelog changes |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #175 +/- ##
=============================================
+ Coverage 69.27% 77.08% +7.80%
- Complexity 1300 1361 +61
=============================================
Files 168 172 +4
Lines 3987 4176 +189
=============================================
+ Hits 2762 3219 +457
+ Misses 1225 957 -268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/8363
Description
Store today's Symfony advisories. One of them did not fit the database and blocked the rest.
Changes:
Advisory:affectedVersions,titleandlinkbecomeTEXT.advisoryId(255) andcve(50) keep their size, with matchingLengthconstraints.AdvisoryFactory::unstorableReason()validates a new advisory before it is persisted. One that does not fit is skipped and logged as an error, instead of failing the flush of the whole result.ReleaseCheckeruses the same check.DetectionResultgetsprocessingErrors, a list of what could not be processed.setAdvisories()returns the skipped advisories, including those for packages the installation does not list, andDockerImageHandlerrecords them.ProcessDetectionResultHandlerclears the list on every run, so a replay shows the current state. Shown on the detection result detail page.TEXTand addsprocessing_errors, filling[]into existing rows.Why:
PKSA-b2gg-vk1g-6d5q(symfony/http-foundation) has a 543-characteraffectedVersions; the column held 500. The failed flush dropped every other new advisory in the same result, so none of the 2026-11-04 Symfony advisories were stored. Skips were only logged as warnings, which prod does not write.Verified on a prod dump: after migrating and replaying the 7 rc2 docker results, all 18 Symfony advisories are stored and no result has processing errors.
Deploy: after deploy, replay the docker results to pick up the advisories that were dropped.
Checklist